Create wishlist.xml #518
Closed
Create wishlist.xml #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwithan8
requested changes
Sep 17, 2024
| Created by Wingysam
 | ||
| Converted by ajb3932</Overview> | ||
| <Category>Productivity: Tools:</Category> | ||
| <WebUI>http://[IP]:[PORT:8023]/</WebUI> |
There was a problem hiding this comment.
Suggested change
| <WebUI>http://[IP]:[PORT:8023]/</WebUI> | |
| <WebUI>http://[IP]:[PORT:80]/</WebUI> |
Fallback needs to be the internal port on the container, in this case 80.
| <DonateText/> | ||
| <DonateLink/> | ||
| <Requires/> | ||
| <Config Name="Web UI" Target="80" Default="80" Mode="tcp" Description="" Type="Port" Display="always" Required="true" Mask="false">8023</Config> |
There was a problem hiding this comment.
Suggested change
| <Config Name="Web UI" Target="80" Default="80" Mode="tcp" Description="" Type="Port" Display="always" Required="true" Mask="false">8023</Config> | |
| <Config Name="Web UI" Target="80" Default="8023" Mode="tcp" Description="" Type="Port" Display="always" Required="true" Mask="false">8023</Config> |
Default in XML should match the pre-filled value.
| <DonateLink/> | ||
| <Requires/> | ||
| <Config Name="Web UI" Target="80" Default="80" Mode="tcp" Description="" Type="Port" Display="always" Required="true" Mask="false">8023</Config> | ||
| <Config Name="List Mode" Target="SINGLE_LIST" Default="false" Mode="" Description="Single list mode (for weddings, birthdays, etc. only the admin account's list is accessible) Set to 'true' to enable" Type="Variable" Display="always" Required="false" Mask="false">true</Config> |
There was a problem hiding this comment.
Suggested change
| <Config Name="List Mode" Target="SINGLE_LIST" Default="false" Mode="" Description="Single list mode (for weddings, birthdays, etc. only the admin account's list is accessible) Set to 'true' to enable" Type="Variable" Display="always" Required="false" Mask="false">true</Config> | |
| <Config Name="Enable Single List Mode" Target="SINGLE_LIST" Default="false|true" Mode="" Description="Single list mode (for weddings, birthdays, etc., only the admin account's list is accessible)." Type="Variable" Display="always" Required="true" Mask="false"/> |
| <Config Name="Web UI" Target="80" Default="80" Mode="tcp" Description="" Type="Port" Display="always" Required="true" Mask="false">8023</Config> | ||
| <Config Name="List Mode" Target="SINGLE_LIST" Default="false" Mode="" Description="Single list mode (for weddings, birthdays, etc. only the admin account's list is accessible) Set to 'true' to enable" Type="Variable" Display="always" Required="false" Mask="false">true</Config> | ||
| <Config Name="Amazon Smile" Target="SMILE" Default="true" Mode="" Description="Amazon Smile, set to 'false' to disable." Type="Variable" Display="always" Required="false" Mask="false">true</Config> | ||
| <Config Name="Data Dir" Target="/data" Default="/mnt/user/appdata/wishlist" Mode="rw" Description="" Type="Path" Display="always" Required="false" Mask="false">/mnt/user/appdata/wishlist</Config> |
There was a problem hiding this comment.
Suggested change
| <Config Name="Data Dir" Target="/data" Default="/mnt/user/appdata/wishlist" Mode="rw" Description="" Type="Path" Display="always" Required="false" Mask="false">/mnt/user/appdata/wishlist</Config> | |
| <Config Name="Data Directory" Target="/data" Default="/mnt/user/appdata/wishlist" Mode="rw" Description="" Type="Path" Display="advanced" Required="true" Mask="false">/mnt/user/appdata/wishlist</Config> |
| <Config Name="List Mode" Target="SINGLE_LIST" Default="false" Mode="" Description="Single list mode (for weddings, birthdays, etc. only the admin account's list is accessible) Set to 'true' to enable" Type="Variable" Display="always" Required="false" Mask="false">true</Config> | ||
| <Config Name="Amazon Smile" Target="SMILE" Default="true" Mode="" Description="Amazon Smile, set to 'false' to disable." Type="Variable" Display="always" Required="false" Mask="false">true</Config> | ||
| <Config Name="Data Dir" Target="/data" Default="/mnt/user/appdata/wishlist" Mode="rw" Description="" Type="Path" Display="always" Required="false" Mask="false">/mnt/user/appdata/wishlist</Config> | ||
| <Config Name="Public Lists" Target="LISTS_PUBLIC" Default="false" Mode="" Description="" Type="Variable" Display="always" Required="false" Mask="false">true</Config> |
There was a problem hiding this comment.
Suggested change
| <Config Name="Public Lists" Target="LISTS_PUBLIC" Default="false" Mode="" Description="" Type="Variable" Display="always" Required="false" Mask="false">true</Config> | |
| <Config Name="Enable Public Lists" Target="LISTS_PUBLIC" Default="false|true" Mode="" Description="" Type="Variable" Display="always" Required="true" Mask="false"/> |
| @@ -0,0 +1,31 @@ | |||
| <?xml version="1.0"?> | |||
| <Container version="2"> | |||
| <Name>Wishlist</Name> | |||
There was a problem hiding this comment.
Suggested change
| <Name>Wishlist</Name> | |
| <Name>Christmas Community</Name> |
Keep the name of the upstream app.
| <Network>bridge</Network> | ||
| <Shell>sh</Shell> | ||
| <Privileged>false</Privileged> | ||
| <Support>https://hub.docker.com/r/wingysam/christmas-community/</Support> |
There was a problem hiding this comment.
Suggested change
| <Support>https://hub.docker.com/r/wingysam/christmas-community/</Support> | |
| <Support>https://github.com/Wingysam/Christmas-Community/issues</Support> |
Point it to the GitHub issues page instead.
| <Shell>sh</Shell> | ||
| <Privileged>false</Privileged> | ||
| <Support>https://hub.docker.com/r/wingysam/christmas-community/</Support> | ||
| <Project>https://github.com/Wingysam/Christmas-Community/tree/master</Project> |
There was a problem hiding this comment.
Suggested change
| <Project>https://github.com/Wingysam/Christmas-Community/tree/master</Project> | |
| <Project>https://github.com/Wingysam/Christmas-Community</Project> |
Remove specific branch in link.
Comment on lines
+11
to
+14
| <Overview>To create a simple place for your entire family to use to find gifts that people want, and to avoid double-gifting.
 | ||
| https://github.com/Wingysam/Christmas-Community/tree/master
 | ||
| Created by Wingysam
 | ||
| Converted by ajb3932</Overview> |
There was a problem hiding this comment.
Suggested change
| <Overview>To create a simple place for your entire family to use to find gifts that people want, and to avoid double-gifting.
 | |
| https://github.com/Wingysam/Christmas-Community/tree/master
 | |
| Created by Wingysam
 | |
| Converted by ajb3932</Overview> | |
| <Overview>A web app for your family's Christmas shopping. Create a simple place for your entire family to use to find gifts that people want, and to avoid double-gifting.</Overview> |
|
Hey sorry I'm kinda new to PRs. I would like to add the devs donate link into |
|
Yes, you can add that, as well as actually resolving the review items. |
|
I'm working on my own wishlist app so will make my own template. Sorry to waste your time. 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A great tool for creating a present wishlist.