Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create wishlist.xml #518

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions templates/wishlist.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
<?xml version="1.0"?>

Check failure on line 1 in templates/wishlist.xml

View workflow job for this annotation

GitHub Actions / lint

Unnecessary Tag

Unnecessary DateInstalled Tag Present
<Container version="2">
<Name>Wishlist</Name>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Name>Wishlist</Name>
<Name>Christmas Community</Name>

Keep the name of the upstream app.

<Repository>wingysam/christmas-community</Repository>
<Registry>https://hub.docker.com/r/wingysam/christmas-community/</Registry>
<Network>bridge</Network>
<Shell>sh</Shell>
ajb3932 marked this conversation as resolved.
Show resolved Hide resolved
<Privileged>false</Privileged>
<Support>https://hub.docker.com/r/wingysam/christmas-community/</Support>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Support>https://hub.docker.com/r/wingysam/christmas-community/</Support>
<Support>https://github.com/Wingysam/Christmas-Community/issues</Support>

Point it to the GitHub issues page instead.

<Project>https://github.com/Wingysam/Christmas-Community/tree/master</Project>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Project>https://github.com/Wingysam/Christmas-Community/tree/master</Project>
<Project>https://github.com/Wingysam/Christmas-Community</Project>

Remove specific branch in link.

<Overview>To create a simple place for your entire family to use to find gifts that people want, and to avoid double-gifting.&#xD;
https://github.com/Wingysam/Christmas-Community/tree/master&#xD;
Created by Wingysam&#xD;
Converted by ajb3932</Overview>
Comment on lines +11 to +14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Overview>To create a simple place for your entire family to use to find gifts that people want, and to avoid double-gifting.&#xD;
https://github.com/Wingysam/Christmas-Community/tree/master&#xD;
Created by Wingysam&#xD;
Converted by ajb3932</Overview>
<Overview>A web app for your family's Christmas shopping. Create a simple place for your entire family to use to find gifts that people want, and to avoid double-gifting.</Overview>

<Category>Productivity: Tools:</Category>
<WebUI>http://[IP]:[PORT:8023]/</WebUI>

Check failure on line 16 in templates/wishlist.xml

View workflow job for this annotation

GitHub Actions / lint

WebUI Port not in Config

WebUI Port 8023 is not a target in Config
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<WebUI>http://[IP]:[PORT:8023]/</WebUI>
<WebUI>http://[IP]:[PORT:80]/</WebUI>

Fallback needs to be the internal port on the container, in this case 80.

<TemplateURL/>
<Icon>https://raw.githubusercontent.com/Wingysam/Christmas-Community/master/src/static/img/logo.transparent.png</Icon>
<ExtraParams/>
<PostArgs/>
<CPUset/>
<DateInstalled>1726584173</DateInstalled>
<DonateText/>
<DonateLink/>
<Requires/>
Comment on lines +19 to +25
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<ExtraParams/>
<PostArgs/>
<CPUset/>
<DateInstalled>1726584173</DateInstalled>
<DonateText/>
<DonateLink/>
<Requires/>

<Config Name="Web UI" Target="80" Default="80" Mode="tcp" Description="" Type="Port" Display="always" Required="true" Mask="false">8023</Config>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Config Name="Web UI" Target="80" Default="80" Mode="tcp" Description="" Type="Port" Display="always" Required="true" Mask="false">8023</Config>
<Config Name="Web UI" Target="80" Default="8023" Mode="tcp" Description="" Type="Port" Display="always" Required="true" Mask="false">8023</Config>

Default in XML should match the pre-filled value.

<Config Name="List Mode" Target="SINGLE_LIST" Default="false" Mode="" Description="Single list mode&#13;&#10; (for weddings, birthdays, etc. only the admin account's list is accessible)&#13;&#10; Set to 'true' to enable" Type="Variable" Display="always" Required="false" Mask="false">true</Config>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Config Name="List Mode" Target="SINGLE_LIST" Default="false" Mode="" Description="Single list mode&#13;&#10; (for weddings, birthdays, etc. only the admin account's list is accessible)&#13;&#10; Set to 'true' to enable" Type="Variable" Display="always" Required="false" Mask="false">true</Config>
<Config Name="Enable Single List Mode" Target="SINGLE_LIST" Default="false|true" Mode="" Description="Single list mode (for weddings, birthdays, etc., only the admin account's list is accessible)." Type="Variable" Display="always" Required="true" Mask="false"/>

<Config Name="Amazon Smile" Target="SMILE" Default="true" Mode="" Description="Amazon Smile, set to 'false' to disable." Type="Variable" Display="always" Required="false" Mask="false">true</Config>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Config Name="Amazon Smile" Target="SMILE" Default="true" Mode="" Description="Amazon Smile, set to 'false' to disable." Type="Variable" Display="always" Required="false" Mask="false">true</Config>
<Config Name="Enable Amazon Smile" Target="SMILE" Default="true|false" Mode="" Description="Use Amazon Smile Links" Type="Variable" Display="always" Required="true" Mask="false"/>

<Config Name="Data Dir" Target="/data" Default="/mnt/user/appdata/wishlist" Mode="rw" Description="" Type="Path" Display="always" Required="false" Mask="false">/mnt/user/appdata/wishlist</Config>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Config Name="Data Dir" Target="/data" Default="/mnt/user/appdata/wishlist" Mode="rw" Description="" Type="Path" Display="always" Required="false" Mask="false">/mnt/user/appdata/wishlist</Config>
<Config Name="Data Directory" Target="/data" Default="/mnt/user/appdata/wishlist" Mode="rw" Description="" Type="Path" Display="advanced" Required="true" Mask="false">/mnt/user/appdata/wishlist</Config>

<Config Name="Public Lists" Target="LISTS_PUBLIC" Default="false" Mode="" Description="" Type="Variable" Display="always" Required="false" Mask="false">true</Config>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Config Name="Public Lists" Target="LISTS_PUBLIC" Default="false" Mode="" Description="" Type="Variable" Display="always" Required="false" Mask="false">true</Config>
<Config Name="Enable Public Lists" Target="LISTS_PUBLIC" Default="false|true" Mode="" Description="" Type="Variable" Display="always" Required="true" Mask="false"/>

</Container>