Use FCMP implementation of BP+ in monero-serai #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayabaNerve
added
improvement
…rity and review This was done as part of my work on FCMPs from Monero, and is copied from https://github.com/kayabaNerve/full-chain-membership-proofs
Monero uses non-transcripted static generators.
It's unused by Monero and accordingly unhelpful.
It's only used for AC proofs
kayabaNerve
force-pushed
the
academic-bp-plus
branch
from
83ce1cc
to
a262fa3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of BP+ from my work on FCMPs for Monero (https://github.com/kayabaNerve/full-chain-membership-proofs) is written to be extremely close to the paper and exceptionally clear. It's also had a good amount of effort spent on optimizations. While those optimizations were mainly for the arithmetic circuit code, this implementation still appears decently faster than the prior impl.
This adds a BP+ impl not descended from Monero's own, and can much more easily be used to verify Monero's impl matches the paper (as it was an effectively clean-room impl successfully modified to match, without any notable changes).