Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use FCMP implementation of BP+ in monero-serai #344

Merged
merged 27 commits into from
Aug 27, 2023
Merged

Use FCMP implementation of BP+ in monero-serai #344

merged 27 commits into from
Aug 27, 2023

Commits on Aug 27, 2023

  1. Add in an implementation of BP+ based off the paper, intended for cla… 

    …rity and review

This was done as part of my work on FCMPs from Monero, and is copied from https://github.com/kayabaNerve/full-chain-membership-proofs
    @kayabaNerve
    kayabaNerve committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    aa188c0 View commit details
    Browse the repository at this point in the history

  2. Remove crate structure of BP+

    @kayabaNerve
    kayabaNerve committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    bf737d4 View commit details
    Browse the repository at this point in the history

  3. Remove arithmetic circuit code

    @kayabaNerve
    kayabaNerve committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    2929f3f View commit details
    Browse the repository at this point in the history

  4. Remove AC/VC generators code

    @kayabaNerve
    kayabaNerve committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    68437e9 View commit details
    Browse the repository at this point in the history

  5. Remove generator transcript 

    Monero uses non-transcripted static generators.
    @kayabaNerve
    kayabaNerve committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    7de4dda View commit details
    Browse the repository at this point in the history

  6. Further trimming of generators

    @kayabaNerve
    kayabaNerve committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    b9b2ab6 View commit details
    Browse the repository at this point in the history

  7. Remove the single range proof 

    It's unused by Monero and accordingly unhelpful.
    @kayabaNerve
    kayabaNerve committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    5b309ff View commit details
    Browse the repository at this point in the history

  8. Work on getting BP+ to compile in its new env

    @kayabaNerve
    kayabaNerve committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    dfc44d0 View commit details
    Browse the repository at this point in the history

  9. Correct BP+ folder name

    @kayabaNerve
    kayabaNerve committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    780d637 View commit details
    Browse the repository at this point in the history

  10. Further tweaks to get closer to compiling

    @kayabaNerve
    kayabaNerve committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    f2970c7 View commit details
    Browse the repository at this point in the history

  11. Remove the ScalarMatrix file 

    It's only used for AC proofs
    @kayabaNerve
    kayabaNerve committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    a73d70f View commit details
    Browse the repository at this point in the history

  12. Compiles, with tests passing

    @kayabaNerve
    kayabaNerve committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    25505e8 View commit details
    Browse the repository at this point in the history

  13. Lock BP+ to Ed25519 instead of the generic Ciphersuite

    @kayabaNerve
    kayabaNerve committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    5cb1d4a View commit details
    Browse the repository at this point in the history

  14. Resolve most warnings in BP+

    @kayabaNerve
    kayabaNerve committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    f576f33 View commit details
    Browse the repository at this point in the history

  15. Make existing bulletproofs test easier to read

    @kayabaNerve
    kayabaNerve committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    942c8ca View commit details
    Browse the repository at this point in the history

  16. Further strip generators

    @kayabaNerve
    kayabaNerve committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    370cc71 View commit details
    Browse the repository at this point in the history

  17. Swap G/H as Monero did

    @kayabaNerve
    kayabaNerve committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    03f7f2c View commit details
    Browse the repository at this point in the history

  18. Replace RangeCommitment with Commitment

    @kayabaNerve
    kayabaNerve committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    505dc60 View commit details
    Browse the repository at this point in the history

  19. Hard-code BP+ h to Ed25519's generator

    @kayabaNerve
    kayabaNerve committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    693cb47 View commit details
    Browse the repository at this point in the history

  20. Use pub(crate) for BP+, not pub

    @kayabaNerve
    kayabaNerve committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    ca29fc3 View commit details
    Browse the repository at this point in the history

  21. Replace initial_transcript with hash_plus

    @kayabaNerve
    kayabaNerve committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    44ce82f View commit details
    Browse the repository at this point in the history

  22. Rename hash_plus to initial_transcript

    @kayabaNerve
    kayabaNerve committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    baa221e View commit details
    Browse the repository at this point in the history

  23. Finish integrating the FCMP BP+ impl

    @kayabaNerve
    kayabaNerve committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    01b01e9 View commit details
    Browse the repository at this point in the history

  24. Move BP+ folder

    @kayabaNerve
    kayabaNerve committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    ab295a2 View commit details
    Browse the repository at this point in the history

  25. Correct no-std support

    @kayabaNerve
    kayabaNerve committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    713f6f3 View commit details
    Browse the repository at this point in the history

  26. Rename "long_n" to eta

    @kayabaNerve
    kayabaNerve committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    a262fa3 View commit details
    Browse the repository at this point in the history

  27. Add note on non-prime order dfg points

    @kayabaNerve
    kayabaNerve committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    7fc4916 View commit details
    Browse the repository at this point in the history