CSharp_刘锦丰_无24 #22
Open
CSharp_刘锦丰_无24 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shangfengh
reviewed
Sep 23, 2023
| { | ||
| lock (this) // 为了线程安全性，在访问共享变量时使用锁来同步线程 | ||
| { | ||
| if (startTime == 0 && elapsedTime == 0) // 进度尚未开始或已经完成 |
There was a problem hiding this comment.
elapsedTime没有及时更新！
elapsedTime也不应当作为字段，而应当随用随算
shangfengh
reviewed
Sep 26, 2023
|
|
||
| public bool Start(long needTime) | ||
| { | ||
| lock (this) // 为了线程安全性，在访问共享变量时使用锁来同步线程 |
There was a problem hiding this comment.
使用lock(this)需谨慎，因为将this作为lock，会使得其完全被占用，不能被其他线程占用。
http://blog.chinaunix.net/uid-7448695-id-2626484
这里有一个简易的理解，为什么对实例采用锁容易死锁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.