-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSharp_刘锦丰_无24 #22
Open
beingnieb
wants to merge
1
commit into
shangfengh:main
Choose a base branch
from
beingnieb:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
CSharp_刘锦丰_无24 #22
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -70,7 +70,74 @@ public class LongProgressByTime: ILongProgressByTime | |
// 只允许修改LongProgressByTime类中的代码 | ||
// 要求实现ILongProgressByTime中的要求 | ||
// 可利用Environment.TickCount64获取当前时间(单位ms) | ||
private long startTime; | ||
private long needTime; | ||
private long elapsedTime; | ||
|
||
public bool Start(long needTime) | ||
{ | ||
lock (this) // 为了线程安全性,在访问共享变量时使用锁来同步线程 | ||
{ | ||
if (startTime == 0 && elapsedTime == 0) // 进度尚未开始或已经完成 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. elapsedTime没有及时更新! |
||
{ | ||
this.needTime = needTime; | ||
startTime = Environment.TickCount64; | ||
return true; | ||
} | ||
else | ||
{ | ||
return false; | ||
} | ||
} | ||
} | ||
|
||
public bool TrySet0() | ||
{ | ||
lock (this) | ||
{ | ||
if (startTime != 0 && elapsedTime == 0) // 进度正在进行中且尚未完成 | ||
{ | ||
startTime = 0; | ||
return true; | ||
} | ||
else | ||
{ | ||
return false; | ||
} | ||
} | ||
} | ||
|
||
public void Set0() | ||
{ | ||
lock (this) | ||
{ | ||
startTime = 0; | ||
} | ||
} | ||
|
||
public (long ElapsedTime, long NeedTime) GetProgress() | ||
{ | ||
lock (this) | ||
{ | ||
if (startTime != 0) | ||
{ | ||
elapsedTime = Environment.TickCount64 - startTime; | ||
if (elapsedTime >= needTime) // 进度已完成 | ||
{ | ||
startTime = 0; | ||
return (elapsedTime, needTime); | ||
} | ||
else // 进度正在进行中 | ||
{ | ||
return (elapsedTime, needTime); | ||
} | ||
} | ||
else // 进度尚未开始或已经完成 | ||
{ | ||
return (0, 0); | ||
} | ||
} | ||
} | ||
//挑战:利用原子操作 | ||
//long.MaxValue非常久 | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
使用lock(this)需谨慎,因为将this作为lock,会使得其完全被占用,不能被其他线程占用。
http://blog.chinaunix.net/uid-7448695-id-2626484
这里有一个简易的理解,为什么对实例采用锁容易死锁