Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't initialize wallet in state.keyring effect #5462

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Oct 13, 2023

Description

Fixes redundant initialization - we already do this in the load() method.
This is only a performance bottleneck for most wallets, however, for Ledger, this means we attempt pairing the device without explicitly having Ledger as a selected wallet.

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

Risk

  • Wallets pairing might be broken, test with all wallets. Tested with Ledger, Native, KK, MM and WCV2

Testing

  • Ensure wallet pairing is still happy against prod for all wallets

Engineering

  • ☝🏽

Operations

  • ☝🏽

Screenshots (if applicable)

Copy link
Contributor Author

gomesalexandre commented Oct 13, 2023

@gomesalexandre gomesalexandre changed the title feat: don't initialize wallet in state.keyring effect fix: don't initialize wallet in state.keyring effect Oct 13, 2023
@gomesalexandre gomesalexandre marked this pull request as ready for review October 13, 2023 19:09
@gomesalexandre gomesalexandre requested a review from a team as a code owner October 13, 2023 19:09
@woodenfurniture woodenfurniture merged commit db8f745 into develop Oct 15, 2023
1 check passed
@woodenfurniture woodenfurniture deleted the feat_perf_lazy_1 branch October 15, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants