-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: lazy load hdwallet adapter modules part 1 #5463
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
gomesalexandre
changed the title
feat: lazy load hdwallet adapter modules
feat: lazy load hdwallet adapter modules part 1
Oct 13, 2023
gomesalexandre
commented
Oct 13, 2023
gomesalexandre
force-pushed
the
feat_perf_lazy_2
branch
from
October 13, 2023 19:20
a5839be
to
4e120d9
Compare
3 tasks
woodenfurniture
force-pushed
the
feat_perf_lazy_1
branch
from
October 15, 2023 21:16
3444d54
to
2d80a3a
Compare
gomesalexandre
force-pushed
the
feat_perf_lazy_2
branch
from
October 16, 2023 07:54
4e120d9
to
9c76875
Compare
3 tasks
woodenfurniture
approved these changes
Oct 17, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
i.e technically lazy loads said packages, but doesn't effectively do so for now, because of this bad boy:
web/src/context/WalletProvider/WalletProvider.tsx
Lines 767 to 783 in a5839be
This however, puts us in a better position to get wallet adapters lazy loaded as a follow-up, the intent being to only populate (and by extension, import the npm packages) adapters when clicking on a wallet option.
Pull Request Type
Issue (if applicable)
Risk
Testing
Engineering
Operations
Screenshots (if applicable)