Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Padring generator upgrade #63

Merged
merged 14 commits into from
Jul 29, 2024
Merged

Padring generator upgrade #63

merged 14 commits into from
Jul 29, 2024

Conversation

aolofsson
Copy link
Member

@aolofsson aolofsson commented Jul 26, 2024 •
edited
Loading

  • Changed parameter TYPE to PROP to be consistent with stdlib
  • Adding support for differential cells requiring modifification of the CELLMAP parameter
  • Improving generate statements to simplify logical and physical debugging
  • Refactoring for consistency/readability
  • Fixing various bugs related to CELLMAP indexing
  • Hardening parameter widths for CELLMAP (for safety)
  • Reordering CELLMAP for ease of use
  • Adding documentation

@aolofsson
Cleaning up iolib documentation/parameteres (wip)
eee931c
@aolofsson
Adding iolib README
6a36e0a
@aolofsson
Cleanin up iopadring CELLMAP (wip)
6b212ea
@aolofsson
Changing TYPE to PROP
db4ddf0 
- Consistent with other lambdalibs
- Moving documentation to README
@aolofsson
README cleanup
1719212
@aolofsson
Finalizing code cleanup in padring
cd28511
@aolofsson
Improving generate naming
3a0382e 
- Adding back the cell name statement within inner loop to help with debugging.
- Turning if-else into ifs to fix issue with nested genblk statements. These are mutually exclusive, so it's not an issue.
@aolofsson
Removing stale padring testbench, not situated inside module
8cf49bb 
- Self contained file
@aolofsson
Adding README for padring generator
b5294c3
@aolofsson aolofsson requested a review from gadfort July 26, 2024 21:14
@aolofsson
Making NULL 0
b4dcf77 
- Fixing testbnench example, pin order was reversed from physical placement order.
gadfort
gadfort requested changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@gadfort gadfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. just some documentation changes I think make sense and a few cells to reconsider.

lambdalib/iolib/README.md Outdated Show resolved Hide resolved
lambdalib/iolib/rtl/la_iopoc.v Show resolved Hide resolved
lambdalib/iolib/rtl/la_ioshort.v Outdated Show resolved Hide resolved
lambdalib/iolib/rtl/la_pt.v Outdated Show resolved Hide resolved
lambdalib/padring/README.md Outdated Show resolved Hide resolved
lambdalib/padring/README.md Outdated Show resolved Hide resolved
@aolofsson aolofsson mentioned this pull request Jul 28, 2024
Closed
@aolofsson aolofsson requested a review from gadfort July 28, 2024 12:10
gadfort
gadfort approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@gadfort gadfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the extra q in the README, otherwise looks good.

lambdalib/padring/README.md
@@ -1,4 +1,4 @@
# PADRING GENERATOR
q# PADRING GENERATOR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stray q

@aolofsson aolofsson merged commit 6232460 into main Jul 29, 2024
3 checks passed
@aolofsson aolofsson deleted the diff_io branch July 29, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadfort gadfort gadfort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aolofsson @gadfort