Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Add .nvmrc #282

Merged
merged 1 commit into from
May 9, 2024
Merged

MNT Add .nvmrc #282

merged 1 commit into from
May 9, 2024

Conversation

emteknetnz
Copy link
Member

Fixes https://github.com/colymba/GridFieldBulkEditingTools/actions/runs/8197203185/job/22418801282#step:12:146

Missing .nvmrc

After merging, manually merge up to 4.0 and ensure that when going from 3 to 4.0 that the 4.0 keeps 18 instead of changing to 10

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I assume you're going to do the "After merging" steps

@GuySartorelli GuySartorelli merged commit 3f0ef1b into 3.1 May 9, 2024
12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/3.1/nvmrc branch May 9, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants