do not change instance name #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good! Could you please bump the version in version.py and add a corresponding note to the CHANGELOG.md? |
|
Formatting failed - you will want to create a local python environment, install development requirements, and run pre-commit. |
|
OK will try that |
|
LMK if it's OK now. Eric |
vsoch
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
singularity-cli change provided instance name when it contains a dash to name with underscore.
dash is legit in instance name (see:
authorizedCharsregexp in https://github.com/sylabs/singularity/blob/main/internal/pkg/instance/instance_linux.go#L69)so do not change the name and delegate instance name validation to singularity.
regards
Eric