Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not change instance name #216

Merged
merged 4 commits into from
Dec 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ The client here will eventually be released as "spython" (and eventually to
singularity on pypi), and the versions here will coincide with these releases.

## [master](https://github.com/singularityhub/singularity-cli/tree/master)
- do not modify user provided instance name when generating new instance (0.3.13)
- bug with instance.run_command (0.3.12)
- added check to enbsure stderr exists upon a non-zero return code when streaming (0.3.11)
- exposed the stream type option, and ability to capture both stdout and stderr when stream=True (0.3.1)
Expand Down
5 changes: 4 additions & 1 deletion spython/instance/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,10 @@ def generate_name(self, name=None):
# If no name provided, use robot name
if name is None:
name = self.RobotNamer.generate()
self.name = name.replace("-", "_")
# dash allowed in instance name.
# authorizedChars = `^[a-zA-Z0-9._-]+$` from instance_linux.go
# self.name = name.replace("-", "_")
self.name = name

def parse_image_name(self, image):
"""
Expand Down
2 changes: 1 addition & 1 deletion spython/version.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# with this file, You can obtain one at http://mozilla.org/MPL/2.0/.


__version__ = "0.3.12"
__version__ = "0.3.13"
AUTHOR = "Vanessa Sochat"
AUTHOR_EMAIL = "[email protected]"
NAME = "spython"
Expand Down