-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT use composition in TableVectorizer #675
Closed
Closed
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
40004e0
MAINT activate common test sklearn
glemaitre 2299f09
iter
glemaitre b524edd
Merge remote-tracking branch 'origin/main' into common_test
glemaitre 57904da
TST make GapEncoder compatible with scikit-learn
glemaitre 4d6602c
iter
glemaitre 2f0cb58
SimilarityEncoder compat
glemaitre 2efa4ad
DatetimeEncoder support
glemaitre 7c379e5
iter
glemaitre b45f48c
iter
glemaitre eae158a
iter
glemaitre 0f778b0
fix ci
glemaitre a3c2255
iter
glemaitre 37c75e8
iter
glemaitre 92087c9
iter
glemaitre 837920f
Merge remote-tracking branch 'origin/main' into improve_table_vectorizer
glemaitre ba9e28b
Merge remote-tracking branch 'origin/main' into improve_table_vectorizer
glemaitre 1ae54eb
MAINT use composition in TableVectorizer
glemaitre 4cf8806
iter
glemaitre 69a8082
iter
glemaitre e56f922
iter
glemaitre 39c1d23
pep8
glemaitre 2ec22f6
iter
glemaitre 3b43b2b
iter
glemaitre d79cace
Merge branch 'main' of https://github.com/skrub-data/skrub into impro…
LilianBoulard cb8ad3b
Clean error
LilianBoulard 6b5e6d3
remove ._columns from table_vectorizer
Vincent-Maladiere bfa8699
Merge branch 'main' into improve_table_vectorizer
Vincent-Maladiere eb793e8
fix tests because I removed 'self.columns_' earlier
Vincent-Maladiere a57dfa0
Merge branch 'main' into improve_table_vectorizer
Vincent-Maladiere 5102457
add properties tests
Vincent-Maladiere 41c5cc6
add docstring to properties
Vincent-Maladiere c0ef079
add get_params and set_params to enable grid_search
Vincent-Maladiere File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LeoGrin and @glemaitre this should fix #709! This is very similar to what is done in
ColumnTransformer