Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] refactor __init__ modules to no longer contain classes #1738

Merged
merged 3 commits into from
Dec 26, 2024

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Dec 26, 2024

This PR refactors the __init__ modules in models, moving any content such as neural network classes to submodules.

Imports will continue working unchanged, as the native contents of the module are still exported.

This is preparing a further structural refactors.

The moved files are also not changed, in order to retain the commit as one that moves files, hence retaining edit history. In order for this to take effect on main, PR #1739 must be merged first (even though this will result in an intermediate, non-passing state).

@fkiraly fkiraly added the enhancement New feature or request label Dec 26, 2024
fkiraly added a commit that referenced this pull request Dec 26, 2024
…aratory commit (#1739)

Preparatory commit for
#1738 to ensure file
edit history is retained, by ensuring that this preparatory PR only
moves files.
@fkiraly fkiraly merged commit 0aac3e2 into main Dec 26, 2024
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant