[ENH] refactor __init__ modules to no longer contain classes - preparatory commit
#1739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
requested review from
benHeid,
fnhirwa,
geetu040,
jdb78,
pranavvp16,
XinyuWuu and
yarnabrina
as code owners
fkiraly
added a commit
that referenced
this pull request
Dec 26, 2024
This PR refactors the `__init__` modules in `models`, moving any content such as neural network classes to submodules. Imports will continue working unchanged, as the native contents of the module are still exported. This is preparing a further structural refactors. The moved files are also not changed, in order to retain the commit as one that moves files, hence retaining edit history. In order for this to take effect on `main`, PR #1739 must be merged first (even though this will result in an intermediate, non-passing state).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparatory commit for #1738 to ensure file edit history is retained, by ensuring that this preparatory PR only moves files.