Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Productionize RMN remote contract #1431

Merged
merged 46 commits into from
Sep 18, 2024
Merged

Productionize RMN remote contract #1431

merged 46 commits into from
Sep 18, 2024

Conversation

RyanRHall
Copy link
Collaborator

@RyanRHall RyanRHall commented Sep 11, 2024 •
edited
Loading

Background

Original PR - there is some discussion here that is possibly still relevant)
Open PR to add cursing - I copied the relevant parts for the RMNRemote.

Note: we are intentionally separating RMNRemote and RMNHome since they have different timelines.

Motivation

Productionize the RMNRemote and include it in integration tests

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 11, 2024 •
edited
Loading

LCOV of commit 57da48d during Solidity Foundry #8237

Summary coverage rate:
  lines......: 97.7% (2279 of 2333 lines)
  functions..: 94.6% (420 of 444 functions)
  branches...: 93.6% (542 of 579 branches)

Files changed coverage rate: n/a

@RyanRHall RyanRHall force-pushed the CCIP-3379-productionize-rmn-remote-and-rmn-home-contracts branch from 304de78 to b025387 Compare September 11, 2024 20:13
RyanRHall
RyanRHall commented Sep 11, 2024
View reviewed changes
contracts/src/v0.8/ccip/rmn/RMNRemote.sol Outdated
Comment on lines 240 to 232
return
s_cursedSubjectsIndexPlusOne[LEGACY_CURSE_SUBJECT] > 0 || s_cursedSubjectsIndexPlusOne[GLOBAL_CURSE_SUBJECT] > 0;
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this legacy compatability stuff I am less familiar with. I would appreciate another set of eyes.

@RyanRHall RyanRHall force-pushed the CCIP-3379-productionize-rmn-remote-and-rmn-home-contracts branch from e434b40 to d199d09 Compare September 12, 2024 16:46
@RyanRHall RyanRHall force-pushed the CCIP-3379-productionize-rmn-remote-and-rmn-home-contracts branch from d199d09 to da72d74 Compare September 12, 2024 17:51
RyanRHall and others added 21 commits September 17, 2024 13:44
@RyanRHall
ignore RMNHome from coverage checks
bcc03c8
@RyanRHall @makramkd
Update comment
255109d 
Co-authored-by: Makram <[email protected]>
@RyanRHall
rename i_chainSelector => i_localChainSelector
3c8008d
@RyanRHall
remove storage / constructor headers
d0da905
@RyanRHall
add comment
325b7a8
@RyanRHall
update comments
711a4b4
@RyanRHall
add new constructor test
bbf4e56
@RyanRHall
improve gas efficiency in verify() function
b4cbb9a
@RyanRHall
PR suggested feedback
75f9ca3
@RyanRHall
rename destLandUpdates => merkleRoots
0644f96
@RyanRHall
rename s_cursedSubjectsSequence to s_cursedSubjects and add comment
22595ea
@RyanRHall
var rename
508abaa
@RyanRHall
Squashed commit of the following:
b80d2f7 
commit aae76b37e0397728ebd1a529a265da4f1dec23bc
Author: Ryan Hall <[email protected]>
Date:   Mon Sep 16 12:46:32 2024 -0400

    fix rebase issues

commit a74b43a8f7ccd3d49cb1dc93e3ba69e2e5343d57
Author: Rens Rooimans <[email protected]>
Date:   Mon Sep 16 11:57:15 2024 +0200

    rm VersionedConfig & emit version and config separate

commit db534f9ff05c150633ac7e94362120bd920f1506
Author: Rens Rooimans <[email protected]>
Date:   Mon Sep 16 11:39:04 2024 +0200

    update some tests

commit 3e86f2149229f7634c35224935dcb08b5ccbf945
Author: Rens Rooimans <[email protected]>
Date:   Mon Sep 16 10:57:45 2024 +0200

    use rawVs from report & fix tests

commit fbe12de74e142cff71c47109ee96be27de168cc4
Author: Rens Rooimans <[email protected]>
Date:   Fri Sep 13 12:55:27 2024 +0200

    demo
@RyanRHall
gas golf verify() function
413a582
@RyanRHall
implement EnumerableSetBytes16 for cursedSubjects
c51a319
@RyanRHall
gas golf verify()
4c44a8b
@RyanRHall
array cleanup
6552764
@RyanRHall
test refactor
74a2487
@RyanRHall
wrappers & snapshot
e8b345c
@RyanRHall
fix solhint issues
4277680
@RyanRHall
update natspec
57da48d
@RyanRHall RyanRHall force-pushed the CCIP-3379-productionize-rmn-remote-and-rmn-home-contracts branch from 4d52586 to 57da48d Compare September 17, 2024 17:44
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@RyanRHall RyanRHall enabled auto-merge (squash) September 17, 2024 18:52
@RyanRHall RyanRHall merged commit f95dce6 into ccip-develop Sep 18, 2024
126 checks passed
@RyanRHall RyanRHall deleted the CCIP-3379-productionize-rmn-remote-and-rmn-home-contracts branch September 18, 2024 07:36
@RyanRHall RyanRHall mentioned this pull request Sep 18, 2024
Merged
RyanRHall added a commit that referenced this pull request Sep 18, 2024
@RyanRHall
Add RMN_V1_6_ANY2EVM_REPORT to RMNRemote and make public (#1447)
0a2d960 
## Motivation

#1431 (comment)

## Solution
Expose the constant as public
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makramkd makramkd makramkd approved these changes

@RayXpub RayXpub RayXpub approved these changes

@gtklocker gtklocker Awaiting requested review from gtklocker

@RensR RensR Awaiting requested review from RensR

@elatoskinas elatoskinas Awaiting requested review from elatoskinas elatoskinas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RyanRHall @gtklocker @RensR @makramkd @elatoskinas @RayXpub