Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only transmit if blue config #145

Merged
merged 4 commits into from
Sep 20, 2024
Merged

only transmit if blue config #145

merged 4 commits into from
Sep 20, 2024

Conversation

makramkd
Copy link
Collaborator

@makramkd makramkd commented Sep 20, 2024 •
edited
Loading

@makramkd makramkd requested a review from a team as a code owner September 20, 2024 10:45
@makramkd makramkd mentioned this pull request Sep 20, 2024
Merged
dimkouv
dimkouv reviewed Sep 20, 2024
View reviewed changes
commit/factory.go Outdated
@@ -66,6 +67,7 @@ type PluginFactory struct {

func NewPluginFactory(
lggr logger.Logger,
donID uint32,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need a type alias for uint32? e.g. type DonID uint32

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, can do a type alias.

commit/report.go Outdated Show resolved Hide resolved
execute/plugin.go Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Test Coverage

Branch Coverage
mk/CCIP-3373 71.6%
main 71.6%

@makramkd makramkd merged commit cf2125c into main Sep 20, 2024
2 of 3 checks passed
@mateusz-sekara mateusz-sekara deleted the mk/CCIP-3373 branch November 8, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimkouv dimkouv dimkouv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@makramkd @dimkouv