Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/capabilities/ccip: bump chainlink-ccip, fix build #14506

Merged
merged 6 commits into from
Sep 20, 2024
Merged

core/capabilities/ccip: bump chainlink-ccip, fix build #14506

merged 6 commits into from
Sep 20, 2024

Conversation

makramkd
Copy link
Contributor

@makramkd makramkd commented Sep 20, 2024 •
edited
Loading

Requires Dependencies

smartcontractkit/chainlink-ccip#145

Resolves Dependencies

smartcontractkit/chainlink-ccip#145

@makramkd makramkd mentioned this pull request Sep 20, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

dimkouv
dimkouv previously approved these changes Sep 20, 2024
View reviewed changes
dimkouv

This comment was marked as spam.

Sign in to view

@makramkd makramkd marked this pull request as ready for review September 20, 2024 16:07
@makramkd makramkd requested review from a team as code owners September 20, 2024 16:07
@makramkd makramkd requested review from vyzaldysanchez and removed request for a team September 20, 2024 16:07
@makramkd makramkd added this pull request to the merge queue Sep 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 20, 2024
@makramkd makramkd added this pull request to the merge queue Sep 20, 2024
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
62.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

Merged via the queue into develop with commit 360ecfb Sep 20, 2024
156 of 157 checks passed
@makramkd makramkd deleted the mk/CCIP-3373/fix-build branch September 20, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimkouv dimkouv dimkouv approved these changes

@connorwstein connorwstein connorwstein approved these changes

@vyzaldysanchez vyzaldysanchez Awaiting requested review from vyzaldysanchez vyzaldysanchez is a code owner automatically assigned from smartcontractkit/foundations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@makramkd @connorwstein @dimkouv