-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1482571: Add CI pipeline for apps unit testing #3
SNOW-1482571: Add CI pipeline for apps unit testing #3
Conversation
environment-file: ${{ matrix.environment-file }} | ||
- name: Install dependencies | ||
run: | | ||
printf "[pytest]\npythonpath=${{ steps.tests_to_run.outputs.pytestPaths }}" > pytest.ini |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be enough to enforce that each individual app has its own pytest.ini
and we can simply delegate to it. I don't think it's necessary to only run changed files -- unless I'm misreading this. Does this just delegate to individual inis?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are dynamically creating that in the root folder since the pytest
command needs it in the folder to be executed. We are running tests from modified sub-repos, and this is why the pytest
command is run globally and not in the individual app.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah got it. OK, that makes sense to me!
Run tests for
n
quantity of sub-repos if there are modified files inside them. E.g.Given the following repo structure:
From the structure above, if there are changes only in
mailorder
andaccount-privileges
, just the tests for these sub-repos are going to be executed.data-mapping
tests don't need to be execute because there are no changes inside the repo.