Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1482571: Add CI pipeline for apps unit testing #3
SNOW-1482571: Add CI pipeline for apps unit testing #3
Changes from 68 commits
d3d88df
97ea167
8de4c42
a2c9798
f933890
e2c6f1e
069f8c1
24bdb0b
e9a44b8
74533cf
ff8b032
dd87a03
40bac16
bb247a3
b49be4b
931c619
ada646b
49573ae
e2cd7f5
68abfa9
ef65f6e
b83eb70
5e6872e
ac8aacc
f342d8f
ec550f6
09118f5
97f9f85
52e8283
dcfc4b7
7572218
622c9f5
34eae21
778417e
11a221a
09af8bb
e7a4542
7439255
4a38651
480b9ad
bb184b9
7c0b384
a03f9e6
4c7edd8
34075bd
875da9b
6c8e068
f69bfa5
e232c05
1522cbd
5c0ea12
9b8fb93
c895600
72fd108
61bef88
daab66d
8223238
1b32603
01d45b3
2a4c688
c0db3f1
7130100
e065feb
82f5a26
6fb36d9
d272767
e77d17b
de51b2e
6b1c110
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be enough to enforce that each individual app has its own
pytest.ini
and we can simply delegate to it. I don't think it's necessary to only run changed files -- unless I'm misreading this. Does this just delegate to individual inis?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are dynamically creating that in the root folder since the
pytest
command needs it in the folder to be executed. We are running tests from modified sub-repos, and this is why thepytest
command is run globally and not in the individual app.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah got it. OK, that makes sense to me!