Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1356685: Add xfails to test_unique.py to resolve flakes when dtype is unsigned int #1441

Merged
merged 3 commits into from
Apr 30, 2024
Merged

SNOW-1356685: Add xfails to test_unique.py to resolve flakes when dtype is unsigned int #1441

merged 3 commits into from
Apr 30, 2024

Conversation

sfc-gh-nkrishna
Copy link
Contributor

@sfc-gh-nkrishna sfc-gh-nkrishna commented Apr 26, 2024 •
edited
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

This PR xfails tests test_unique_homogeneous_data and test_unique_post_sort_values to unblock daily CI runs. I filed https://snowflakecomputing.atlassian.net/browse/SNOW-1356685 which describes the issue.

@sfc-gh-nkrishna sfc-gh-nkrishna requested a review from a team as a code owner April 26, 2024 19:30
@sfc-gh-nkrishna sfc-gh-nkrishna changed the title Remove large data values from test_unique.py to resolve flakes TEST: Remove large data values from test_unique.py to resolve flakes Apr 26, 2024
@sfc-gh-nkrishna sfc-gh-nkrishna added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGELOG-UPDATES NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs labels Apr 26, 2024
sfc-gh-lspiegelberg
sfc-gh-lspiegelberg reviewed Apr 26, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-lspiegelberg sfc-gh-lspiegelberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not 100% sure I get the intent of this PR. xfail may be a better path forward, would like to learn more.

tests/integ/modin/series/test_unique.py Show resolved Hide resolved
@sfc-gh-nkrishna
Copy link
Contributor Author

@sfc-gh-azhan @sfc-gh-lspiegelberg I filed a JIRA ticket describing the issue and am temporarily xfailing these tests to unblock CI. Can you PTAL?

sfc-gh-lspiegelberg
sfc-gh-lspiegelberg approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-lspiegelberg sfc-gh-lspiegelberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use the ticket number SNOW-1356685 in title/description when merging so we can track this. else, lgtm.

@sfc-gh-nkrishna sfc-gh-nkrishna changed the title TEST: Remove large data values from test_unique.py to resolve flakes Add xfails to test_unique.py to resolve flakes (see SNOW-1356685) Apr 30, 2024
@sfc-gh-nkrishna sfc-gh-nkrishna changed the title Add xfails to test_unique.py to resolve flakes (see SNOW-1356685) SNOW-1356685: Add xfails to test_unique.py to resolve flakes when dtype is unsigned int Apr 30, 2024
@sfc-gh-nkrishna sfc-gh-nkrishna enabled auto-merge (squash) April 30, 2024 17:58
@sfc-gh-nkrishna sfc-gh-nkrishna merged commit 9e7d07e into main Apr 30, 2024
26 checks passed
@sfc-gh-nkrishna sfc-gh-nkrishna deleted the test_unique_flake branch April 30, 2024 18:03
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-lspiegelberg sfc-gh-lspiegelberg sfc-gh-lspiegelberg approved these changes

@sfc-gh-azhan sfc-gh-azhan sfc-gh-azhan approved these changes

@sfc-gh-nkumar sfc-gh-nkumar Awaiting requested review from sfc-gh-nkumar sfc-gh-nkumar was automatically assigned from snowflakedb/snowpandas

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-nkrishna @sfc-gh-azhan @sfc-gh-lspiegelberg