Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1356685: Add xfails to test_unique.py to resolve flakes when dtype is unsigned int #1441

Merged
merged 3 commits into from
Apr 30, 2024
Merged

SNOW-1356685: Add xfails to test_unique.py to resolve flakes when dtype is unsigned int #1441

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d5ba69
Remove large data values from test_unique.py to resolve flakes
sfc-gh-nkrishna Apr 26, 2024
4727c52
change to 2**34
sfc-gh-nkrishna Apr 29, 2024
c9d11f9
Add xfails to test_unique to unblock daily CI run
sfc-gh-nkrishna Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tests/integ/modin/series/test_unique.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,12 @@ def _make_nan_interleaved_float_series():
[12.0, 11.999999, 11.999999],
["A", "A", "C", "C", "A"],
[None, "A", None, "B"],
sfc-gh-nkrishna marked this conversation as resolved.
Show resolved Hide resolved
native_pd.Series([1, 2, 2**63, 2**63], dtype=np.uint64),
pytest.param(
native_pd.Series([1, 2, 2**63, 2**63], dtype=np.uint64),
marks=pytest.mark.xfail(
reason="SNOW-1356685: Dtype with unsigned int results in precision error"
),
),
_make_nan_interleaved_float_series(),
]

Expand Down
Loading