SNOW-1347394: Remove BaseQueryCompiler + error in QC default to pandas

[sfc-gh-joshi]

Please answer these questions before submitting your pull requests. Thanks!

1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

   Fixes SNOW-1347394

2. Fill out the following pre-review checklist:

   • I am adding a new automated test(s) to verify correctness of my new code
   • I am adding new logging messages
   • I am adding a new telemetry message
   • I am adding new credentials
   • I am adding a new dependency

3. Please describe how your code solves the related issue.

This PR removes our vendored copy of the BaseQueryCompiler class, inheriting the class from upstream Modin instead. Similarly, it removes all the operator registration classes defined in snowflake.snowpark.modin.core.dataframe.algebra.default2pandas, with one exception. Upstream Modin does not properly render the names of property objects (modin-project/modin#7233), so we should override DataFrameDefault.register to fix this until this issue is fixed upstream.

This PR incidentally removes Series.dt.week + Series.dt.weekofyear, which were already removed in pandas 2.0.

[sfc-gh-nkrishna]

Thanks @sfc-gh-joshi!

[sfc-gh-vbudati]

Thanks Jonathan!

[sfc-gh-nkumar]

nit: ...doesn't yet support the method {object_type}.{fn_name}

[sfc-gh-joshi]

Do we not want the message to include the specified parameters? Some query compiler methods directly call DataFrameDefault.register when certain parameter combinations are encountered, while the method is generally supported.

…

On Tue, Apr 30, 2024 at 17:34 Naresh Kumar ***@***.***> wrote: ***@***.**** approved this pull request. ------------------------------ In src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py <#1454 (comment)> : > - ) - return_query_compiler.snowpark_pandas_api_calls.append( - { - TelemetryField.NAME.value: f"{object_type}.{fn_name}", - SnowparkPandasTelemetryField.IS_FALLBACK.value: True, - } + # Previously, Snowpark pandas would register a stored procedure that materializes the frame + # and performs the native pandas operation. Because this fallback has extremely poor + # performance, we now raise NotImplementedError instead. + args_str = ", ".join(map(str, args)) + if args and kwargs: + args_str += ", " + if kwargs: + args_str += ", ".join(f"{key}={value}" for key, value in kwargs.items()) + ErrorMessage.not_implemented( + f"Snowpark pandas doesn't yet support {object_type}.{fn_name}({args_str}" nit: ...doesn't yet support the method {object_type}.{fn_name} — Reply to this email directly, view it on GitHub <#1454 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BDT7LZVBBULMQ3PNKXN5IMTZAA2C7AVCNFSM6AAAAABG7D2UY6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMZSHA2TOMBVGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>