Release pipeline #178
Merged
Release pipeline #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkozyra95
force-pushed
the
@wkozyra95/setup-compositor-release
branch
29 times, most recently
from
55ce25b
to
066a83a
Compare
wkozyra95
commented
Sep 28, 2023
| @@ -140,11 +141,14 @@ fn download_cef(cef_root_path: &Path) -> Result<()> { | |||
| let download_path = cef_root_path | |||
| .parent() | |||
| .context("Failed to retrieve CEF_ROOT parent directory")?; | |||
| let url = format!("https://cef-builds.spotifycdn.com/cef_binary_117.1.4%2Bga26f38b%2Bchromium-117.0.5938.92_{platform}_minimal.tar.bz2"); | |||
| let url = format!("https://cef-builds.spotifycdn.com/cef_binary_115.3.11%2Bga61da9b%2Bchromium-115.0.5790.114_{platform}_minimal.tar.bz2"); | |||
There was a problem hiding this comment.
temporary revert to make sure it builds
| let client = reqwest::blocking::ClientBuilder::new() | ||
| .timeout(Duration::from_secs(2 * 60)) | ||
| .build()?; | ||
| let resp = client.get(url).send()?; | ||
| let resp = client.get(&url).send()?; | ||
| if resp.status() != StatusCode::OK { |
There was a problem hiding this comment.
send throws error only when request itself fails, responses like 404 are considered success, so we need to check status code explicitlly
wkozyra95
force-pushed
the
@wkozyra95/setup-compositor-release
branch
2 times, most recently
from
9206509
to
a69f5bb
Compare
wkozyra95
force-pushed
the
@wkozyra95/setup-compositor-release
branch
from
a69f5bb
to
adaba57
Compare
|
Merging because I need to verify some things on master, I'll address any comments in follow up. |
Comment on lines
+42
to
+44
| panic!( | ||
| "Build process helper first: cargo build --bin process_helper. {:?}", | ||
| err |
There was a problem hiding this comment.
Maybe add note about -r
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release process for Linux binaries + docs