-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release pipeline #178
Merged
Merged
Release pipeline #178
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
name: package for release | ||
on: | ||
workflow_dispatch: {} | ||
|
||
jobs: | ||
linux: | ||
runs-on: ubuntu-latest | ||
container: | ||
image: ubuntu:mantic-20230712 | ||
steps: | ||
- name: 🛠 Install system dependencies | ||
run: | | ||
apt-get update -y -qq | ||
apt-get install -y libegl1-mesa-dev libgl1-mesa-dri libxcb-xfixes0-dev ffmpeg libavcodec-dev libavformat-dev libavfilter-dev libavdevice-dev | ||
# TMP until we need to build in docker container | ||
apt-get install -y curl build-essential curl pkg-config libssl-dev libclang-dev git libnss3 libatk1.0-0 libatk-bridge2.0-0 libgdk-pixbuf2.0-0 libgtk-3-0 | ||
- name: 🔧 Install the rust toolchain | ||
uses: dtolnay/rust-toolchain@stable | ||
|
||
- name: 📥 Checkout repo | ||
uses: actions/checkout@v3 | ||
|
||
- name: 📦 Package | ||
run: cargo run --bin package_for_release --features standalone | ||
|
||
- uses: actions/upload-artifact@v3 | ||
with: | ||
name: video_compositor_linux_x86_64.tar.gz | ||
path: video_compositor_linux_x86_64.tar.gz | ||
|
||
macos: | ||
runs-on: macos-latest | ||
steps: | ||
- name: 🛠 Install system dependencies | ||
run: brew install ffmpeg | ||
|
||
- name: 🔧 Install the rust toolchain | ||
uses: dtolnay/rust-toolchain@stable | ||
|
||
- name: 📥 Checkout repo | ||
uses: actions/checkout@v3 | ||
|
||
- name: 📦 Package | ||
run: cargo run --bin package_for_release --features standalone | ||
|
||
- uses: actions/upload-artifact@v3 | ||
with: | ||
name: video_compositor_darwin_x86_64.app.tar.gz | ||
path: video_compositor_darwin_x86_64.app.tar.gz |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
name: shellcheck | ||
on: | ||
push: | ||
branches: [master] | ||
paths: | ||
- "scripts/*" | ||
- .github/workflows/shellcheck.yml | ||
pull_request: | ||
types: [opened, synchronize] | ||
paths: | ||
- "scripts/*" | ||
- .github/workflows/shellcheck.yml | ||
|
||
concurrency: | ||
group: ${{ github.workflow }}-${{ github.ref }} | ||
cancel-in-progress: ${{ github.ref != 'refs/heads/master' }} | ||
|
||
jobs: | ||
dockerfile: | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v2 | ||
|
||
- name: shellcheck | ||
run: | | ||
shellcheck ./scripts/release.sh ./scripts/compositor_runtime_wrapper.sh |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
# Release | ||
|
||
To release a new compositor version: | ||
|
||
- Go to `Actions` -> [`package for release`](https://github.com/membraneframework/video_compositor/actions/workflows/release.yml) -> Dispatch new workflow on a master branch. | ||
- Wait for a build to finish. | ||
- Run `gh run list --workflow "package for release"` and find ID of workflow run you just run. | ||
- Run `WORKFLOW_RUN_ID={WORKFLOW_RUN_ID} RELEASE_TAG={VERSION} ./scripts/release.sh` where `WORKFLOW_RUN_ID` is an ID from the previous step, and `VERSION` has a format `v{major}.{minor}.{patch}`. e.g. `WORKFLOW_RUN_ID=6302155380 RELEASE_TAG=v1.2.3 ./scripts/release.sh ` | ||
|
||
|
||
### Temporary workaround for macOS M1 binaries | ||
|
||
Currently we do not have a CI to build for macOS M1, so for now compositor releases are run from a developer device. | ||
|
||
To publish binaries for M1 devices, first follow instructions above for other platform. After GitHub release is created you can add binaries for M1 by running bellow command on M1 mac. | ||
|
||
```bash | ||
RELEASE_TAG={VERSION} cargo run --bin package_for_release --features standalone | ||
``` | ||
|
||
e.g. | ||
```bash | ||
RELEASE_TAG=v1.2.3 cargo run --bin package_for_release --features standalone | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
send throws error only when request itself fails, responses like 404 are considered success, so we need to check status code explicitlly