More generator updates #198
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- only install chrome, which is the default driver - stop using sqlite-memory - add a sqlite based job - test against different ruby version (with minimal redundancy)
- shadow the bundle command and make it run "with unbundled env" - shed support for the legacy `with_clean_env` - use local bundle config instead of the deprecated inline flags - generalize support for extensions installed by `solidus:install` - thinner layer between env variables and `rails new` options - mark the main operation to ease debugging issues
Require a version of bundler that supports `--path` in the `add` command.
We need to skip solidus bolt for Solidus v3.2, otherwise it will try to install it when creating the dummy app.
mergify
bot
added
the
needs changelog label
|
It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:
Additionally, the maintainer may also want to add one of the following:
Once the correct labels have been set, simply remove the |
1 similar comment
|
It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:
Additionally, the maintainer may also want to add one of the following:
Once the correct labels have been set, simply remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Those changes are sourced from adjustments done on individual extensions.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed (
cross them outif they are not):