Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More generator updates #198

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

More generator updates #198

wants to merge 10 commits into from

Commits on Dec 20, 2022

  1. Setup dummy app ENV vars before requiring core support files

    @elia
    elia committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    398962d View commit details
    Browse the repository at this point in the history

  2. Streamline the proposed CircleCI configuration 

    - only install chrome, which is the default driver
- stop using sqlite-memory
- add a sqlite based job
- test against different ruby version (with minimal redundancy)
    @elia
    elia committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    b4197c2 View commit details
    Browse the repository at this point in the history

  3. Streamline bin/sandbox 

    - shadow the bundle command and make it run "with unbundled env"
- shed support for the legacy `with_clean_env`
- use local bundle config instead of the deprecated inline flags
- generalize support for extensions installed by `solidus:install`
- thinner layer between env variables and `rails new` options
- mark the main operation to ease debugging issues
    @elia
    elia committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    4153af5 View commit details
    Browse the repository at this point in the history

  4. Support for Bundler.with_unbundled_env is now common

    @elia
    elia committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    f5119d0 View commit details
    Browse the repository at this point in the history

  5. Use the #sh helper in the spec to add debugging support

    @elia
    elia committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    9943690 View commit details
    Browse the repository at this point in the history

  6. Initialize the extension dir with git

    @elia
    elia committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    0d48252 View commit details
    Browse the repository at this point in the history

  7. Use bundle add --path to setup the sandbox 

    Require a version of bundler that supports `--path` in the `add`
command.
    @elia
    elia committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    f92a4ac View commit details
    Browse the repository at this point in the history

  8. Use an absolute path when adding dev-support to the gemfile

    @elia
    elia committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    d0095f7 View commit details
    Browse the repository at this point in the history

  9. Skip solidus_bolt when creating the dummy app 

    We need to skip solidus bolt for Solidus v3.2, otherwise it will try
to install it when creating the dummy app.
    @elia
    elia committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    cf334f4 View commit details
    Browse the repository at this point in the history

  10. elia/updates: [wip]

    @elia
    elia committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    f7c8fbd View commit details
    Browse the repository at this point in the history