Use server GracefulStop instead of force stop #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
Apr 24, 2024
rlucus
approved these changes
May 10, 2024
ganglyu
reviewed
Jul 2, 2024
| stopSignalHandler <- true | ||
| log.Flush() | ||
| return | ||
| } | ||
| s.Stop() // Graceful stop |
There was a problem hiding this comment.
Why not stop signalHandler and flush log?
There was a problem hiding this comment.
s.Stop() is a graceful stop which is only reserved for cert rotation. Since we are not trying to exit process, just stop the server, we will not need to return or flush logs.
ganglyu
previously approved these changes
Jul 2, 2024
ganglyu
approved these changes
Jul 2, 2024
|
Cherry-pick PR to 202405: #282 |
mssonicbld
pushed a commit
that referenced
this pull request
Aug 24, 2024
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
It is better for server to gracefully stop after all pending requests are finished while blocking incoming requests instead of force closing all requests.
How I did it
Use GracefulStop API instead of Stop
How to verify it
UT, will add sonic-mgmt testcase
Verified via manual test that if during server is serving request, if certs are modified, server will not force close request, but will in fact finish the request and then server will be closed and that no new request is allowed. Will create a sonic-mgmt testcase for this.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)