Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use server GracefulStop instead of force stop #219

Merged
merged 9 commits into from
Jul 2, 2024
Merged

Use server GracefulStop instead of force stop #219

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
110326b
Add graceful stop
zbud-msft Apr 23, 2024
91d04af
Use force stop for non cert rotation signals
zbud-msft Jul 1, 2024
f28e6f5
Merge branch 'master' into add_graceful_stop
zbud-msft Jul 1, 2024
026a56e
Fix UT
zbud-msft Jul 2, 2024
72d50a6
Add UT for graceful stop
zbud-msft Jul 2, 2024
985871a
Merge branch 'add_graceful_stop' of github.com:zbud-msft/sonic-gnmi i…
zbud-msft Jul 2, 2024
191ce8e
Add coverage for force stop
zbud-msft Jul 2, 2024
668b996
Add additional UT
zbud-msft Jul 2, 2024
73f9ff1
Merge branch 'master' into add_graceful_stop
zbud-msft Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gnmi_server/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ func (srv *Server) Stop() {
log.Errorf("Stop() failed: not initialized")
return
}
s.Stop()
s.GracefulStop()
zbud-msft marked this conversation as resolved.
Show resolved Hide resolved
}

// Address returns the port the Server is listening to.
Expand Down
5 changes: 5 additions & 0 deletions gnmi_server/server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3503,11 +3503,13 @@ func TestConnectionsKeepAlive(t *testing.T) {
},
}
for _, tt := range(tests) {
var clients []*cacheclient.CacheClient
for i := 0; i < 5; i++ {
t.Run(tt.desc, func(t *testing.T) {
q := tt.q
q.Addrs = []string{"127.0.0.1:8081"}
c := client.New()
clients = append(clients, c)
wg := new(sync.WaitGroup)
wg.Add(1)

Expand All @@ -3529,6 +3531,9 @@ func TestConnectionsKeepAlive(t *testing.T) {
}
})
}
for _, cacheClient := range(clients) {
cacheClient.Close()
}
}
}

Expand Down
Loading