Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for RebootMethod_HALT for Reboot API #286

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vvolam
Copy link

@vvolam vvolam commented Sep 10, 2024

Why I did it

Add support for HALT reboot method for Reboot gNOI API

How I did it

Implement changes for HaltSystem() function to be called when HALT reboot method is invoked.

How to verify it

Unit tests

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@vvolam vvolam marked this pull request as ready for review September 13, 2024 23:24
gnmi_server/gnoi.go Outdated Show resolved Hide resolved
sonic_service_client/dbus_client.go Outdated Show resolved Hide resolved
test/test_gnoi.py Outdated Show resolved Hide resolved
test/test_gnoi.py Outdated Show resolved Hide resolved
hdwhdw
hdwhdw previously approved these changes Sep 18, 2024
@qiluo-msft
Copy link
Collaborator

Do not change a file with only empty lines in diff.


Refers to: gnoi_client/gnoi_client.go:353 in 5f81358. [](commit_id = 5f81358, deletion_comment = False)

@vvolam
Copy link
Author

vvolam commented Sep 20, 2024

Do not change a file with only empty lines in diff.

Refers to: gnoi_client/gnoi_client.go:353 in 5f81358. [](commit_id = 5f81358, deletion_comment = False)

@qiluo-msft Removed the empty lines change. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants