-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose GameTitle, WindowIconSet and SplashLogo to content #5475
Merged
PJB3005
merged 6 commits into
space-wizards:master
from
VasilisThePikachu:gametitle-public
Oct 1, 2024
Merged
Expose GameTitle, WindowIconSet and SplashLogo to content #5475
PJB3005
merged 6 commits into
space-wizards:master
from
VasilisThePikachu:gametitle-public
Oct 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requirement for upstream ss14 pr
VasilisThePikachu
requested review from
PJB3005 and
DrSmugleaf
as code owners
September 30, 2024 16:07
VasilisThePikachu
added a commit
to VasilisThePikachu/space-station-14
that referenced
this pull request
Sep 30, 2024
2 tasks
PJB3005
requested changes
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be a general purpose API that can expose other info in the resource manifest too, like the window icon set or splash logo.
I don't think its worth it to add the other stuff (modules, assemblyprefix, autocnnect, clientassemblies)
VasilisThePikachu
changed the title
Expose GameTitle to public
Expose GameTitle, WindowIconSet and SplashLogo to content
Sep 30, 2024
PJB3005
pushed a commit
to space-wizards/space-station-14
that referenced
this pull request
Oct 17, 2024
* Change the window titlebar to show the joined server Requires space-wizards/RobustToolbox#5475 * Totally not a webedit * Can you tell what cvar I copied? * And this kids is why we don't webedit * Reviews --------- Co-authored-by: metalgearsloth <[email protected]>
deltanedas
pushed a commit
to deltanedas/Delta-v
that referenced
this pull request
Oct 24, 2024
* Change the window titlebar to show the joined server Requires space-wizards/RobustToolbox#5475 * Totally not a webedit * Can you tell what cvar I copied? * And this kids is why we don't webedit * Reviews --------- Co-authored-by: metalgearsloth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirement for upstream ss14 pr