Fixed modify setting file have no effect #338
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What effect will this have on users who have already configured DocBlockr using their regular preferences file? |
|
Their regular preferences file is invalid. This pull request just fix this bug. I rename “Base File.sublime-settings” to “ DocBlockr.sublime-settings”. Because there is a space within the filename. If users have modify preference file. They should copy file content to “ DocBlockr.sublime-settings”. |
|
@fanhexin Thanks a lot for this fix. I downloaded the one from your repository and installed it. It was very annoying not being able to configure the plugin! |
gerardroche
added a commit
to gerardroche/sublime-doc-blockr
that referenced
this pull request
Jul 7, 2016
* Fixes spadgos#313 * Fixes spadgos#334 * Fixes spadgos#338 * Fixes spadgos#408 * Fixes spadgos#400 * Fixes spadgos#360 * Fixes spadgos#397
gerardroche
added a commit
to gerardroche/sublime-doc-blockr
that referenced
this pull request
Aug 17, 2016
* Fixes spadgos#313 * Fixes spadgos#334 * Fixes spadgos#338 * Fixes spadgos#408 * Fixes spadgos#400 * Fixes spadgos#360 * Fixes spadgos#397
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And this fix resolve #313