Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gemfile: add ruby RUBY_VERSION version hint #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

olleolleolle
Copy link

  • this helps bundler choose the right versions of gems for older Rubies.

(Until Bundler can figure all of this out on its own, we can regenerate the lockfile on each build.)

@olleolleolle
Copy link
Author

  • This makes the 1.9.3 build work
  • The 1.8.7 build can never work since its URI module does not have #encode_www_form
  • ree is also 1.8.7 - ree-1.8.7-2012.02 and fails for the same reason
Error: test_upgrade_mozillastore(TestHTTPCookieJar::WithMozillaStore)
  NoMethodError: undefined method `encode_www_form' for URI:Module
/home/travis/build/sparklemotion/http-cookie/lib/http/cookie_jar/mozilla_store.rb:303:in `upgrade_database'

@knu
Copy link
Member

knu commented Dec 9, 2016

It was an accident that 1.8 compatibility was broken, http-cookie still supports 1.8.

@olleolleolle
Copy link
Author

@knu Cool!

  • rebased
  • added back ree, 1.8.7
  • added the RUBY_VERSION marker to Gemfile
  • added exact versions to JRuby Travis builds

@olleolleolle
Copy link
Author

olleolleolle commented Dec 9, 2016

Perhaps we can talk about whether to keep rbx-2 in the matrix, instead?

Example build result

Requested binary installation but no rubies are available to download, consider skipping --binary flag.
Gemset '' does not exist, 'rvm rbx-2 do rvm gemset create ' first, or append '--create'.

@knu
Copy link
Member

knu commented Dec 9, 2016

@olleolleolle I think we can drop support for rbx-2.

.travis.yml Outdated
- jruby-1.7
- jruby-9
- jruby-1.7.26
- jruby-9.1.6.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this change? I don't like to hard-code minor versions. For jruby-9.1.x you could just say jruby, if jruby-9 pointed to jruby-9.0.x.

@@ -1,4 +1,5 @@
source 'https://rubygems.org'

# Specify your gem's dependencies in http-cookie.gemspec
ruby RUBY_VERSION
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I could just merge this part, since that's what this PR is about.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the other changes; would this make it mergeable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants