-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gemfile: add ruby RUBY_VERSION version hint #18
base: master
Are you sure you want to change the base?
Conversation
|
It was an accident that 1.8 compatibility was broken, http-cookie still supports 1.8. |
@knu Cool!
|
Perhaps we can talk about whether to keep rbx-2 in the matrix, instead?
|
@olleolleolle I think we can drop support for rbx-2. |
.travis.yml
Outdated
- jruby-1.7 | ||
- jruby-9 | ||
- jruby-1.7.26 | ||
- jruby-9.1.6.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this change? I don't like to hard-code minor versions. For jruby-9.1.x you could just say jruby
, if jruby-9
pointed to jruby-9.0.x.
@@ -1,4 +1,5 @@ | |||
source 'https://rubygems.org' | |||
|
|||
# Specify your gem's dependencies in http-cookie.gemspec | |||
ruby RUBY_VERSION |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I could just merge this part, since that's what this PR is about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the other changes; would this make it mergeable?
(Until Bundler can figure all of this out on its own, we can regenerate the lockfile on each build.)