Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gemfile: add ruby RUBY_VERSION version hint #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Gemfile: add ruby RUBY_VERSION version hint #18

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4388b48
Travis: add Ruby version to Gemfile
olleolleolle Dec 9, 2016
5553a4e
Update .travis.yml
olleolleolle Sep 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ rvm:
- 2.2
- 2.3.0
- ruby-head
- jruby-1.7
- jruby-9
- jruby-1.7.26
- jruby-9.1.6.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this change? I don't like to hard-code minor versions. For jruby-9.1.x you could just say jruby, if jruby-9 pointed to jruby-9.0.x.

- rbx-2
matrix:
allow_failures:
Expand Down
3 changes: 2 additions & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
source 'https://rubygems.org'

# Specify your gem's dependencies in http-cookie.gemspec
ruby RUBY_VERSION
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I could just merge this part, since that's what this PR is about.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the other changes; would this make it mergeable?


gemspec