-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaning classes #360
base: v3-dev
Are you sure you want to change the base?
Cleaning classes #360
Conversation
src/specklepy/objects/__init__.py
Outdated
@@ -19,5 +11,4 @@ | |||
"units", | |||
"structural", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't structural be removed as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3-dev #360 +/- ##
==========================================
- Coverage 89.62% 88.24% -1.38%
==========================================
Files 128 119 -9
Lines 6815 6034 -781
==========================================
- Hits 6108 5325 -783
- Misses 707 709 +2 ☔ View full report in Codecov by Sentry. |
@@ -68,4 +70,8 @@ | |||
"Streams", | |||
"Activity", | |||
"ActivityCollection", | |||
"InstanceProxy", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see some proxy classes were added, but looks like renderMaterialProxy
is missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently it relies on RenderMaterial
which is in Objects
, not Core
. Both would have to be moved to Core
if so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, noticed it, added it to the same place as in C#
lets hold off a bit on adding new classes, maybe even deleting. We're probably going to do a similar v2-v3 fork we did in Objects for specklepy. |
Removing GIS classes, adding instances and proxies: https://linear.app/speckle/issue/CNX-859/objects-alignment
Data objects, interfaces and their inheritance is ignored for now