Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning classes #360

Open
wants to merge 16 commits into
base: v3-dev
Choose a base branch
from
Open

Cleaning classes #360

wants to merge 16 commits into from

Conversation

KatKatKateryna
Copy link
Contributor

@KatKatKateryna KatKatKateryna commented Dec 5, 2024

Removing GIS classes, adding instances and proxies: https://linear.app/speckle/issue/CNX-859/objects-alignment
Data objects, interfaces and their inheritance is ignored for now

@@ -19,5 +11,4 @@
"units",
"structural",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't structural be removed as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed!

@KatKatKateryna KatKatKateryna marked this pull request as draft December 5, 2024 17:11
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 40 lines in your changes missing coverage. Please review.

Project coverage is 88.24%. Comparing base (bd38dfa) to head (58b04c2).

Files with missing lines Patch % Lines
tests/unit/test_instances.py 28.57% 20 Missing ⚠️
tests/unit/test_proxies.py 28.57% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           v3-dev     #360      +/-   ##
==========================================
- Coverage   89.62%   88.24%   -1.38%     
==========================================
  Files         128      119       -9     
  Lines        6815     6034     -781     
==========================================
- Hits         6108     5325     -783     
- Misses        707      709       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -68,4 +70,8 @@
"Streams",
"Activity",
"ActivityCollection",
"InstanceProxy",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some proxy classes were added, but looks like renderMaterialProxy is missing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm I see, shall we move it in C# accordingly as well? Right now it's not in Proxies classes list
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently it relies on RenderMaterial which is in Objects, not Core. Both would have to be moved to Core if so

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, noticed it, added it to the same place as in C#

@gjedlicska
Copy link
Collaborator

lets hold off a bit on adding new classes, maybe even deleting.

We're probably going to do a similar v2-v3 fork we did in Objects for specklepy.

@KatKatKateryna KatKatKateryna marked this pull request as ready for review December 6, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants