-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaning classes #360
base: v3-dev
Are you sure you want to change the base?
Cleaning classes #360
Changes from 8 commits
21249f0
3362d09
eafa6f2
edfb515
8e0d47b
3ea301f
0a918ae
6c154b0
9358496
46b56b9
f33bbbd
7d25b6b
4ff2931
58b04c2
71ca531
0fcc305
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
from specklepy.objects.base import Base | ||
|
||
|
||
class InstanceProxy( | ||
Base, | ||
speckle_type="Speckle.Core.Models.Instances.InstanceProxy", | ||
): | ||
""" | ||
A proxy class for an instance (e.g, a rhino block, or an autocad block reference). | ||
""" | ||
|
||
definitionId: str | ||
transform: list[float] | ||
units: str | ||
maxDepth: int | ||
|
||
|
||
class InstanceDefinitionProxy( | ||
Base, | ||
speckle_type="Speckle.Core.Models.Instances.InstanceDefinitionProxy", | ||
): | ||
""" | ||
A proxy class for an instance definition. | ||
""" | ||
|
||
objects: list[str] | ||
maxDepth: int | ||
name: str |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
from specklepy.objects.base import Base | ||
|
||
|
||
class ColorProxy( | ||
Base, | ||
speckle_type="Speckle.Core.Models.Proxies.ColorProxy", | ||
): | ||
""" | ||
Represents a color that is found on objects and collections in a root collection. | ||
""" | ||
|
||
objects: list[str] | ||
value: int | ||
name: str | None # nullable but required | ||
|
||
|
||
class GroupProxy( | ||
Base, | ||
speckle_type="Speckle.Core.Models.Proxies.GroupProxy", | ||
): | ||
""" | ||
Grouped objects with a meaningful way for host application so use this proxy if you want to group object references for any purpose. | ||
i.e. in rhino -> creating group make objects selectable/moveable/editable together. | ||
""" | ||
|
||
objects: list[str] | ||
name: str |
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,6 @@ | ||
"""Builtin Speckle object kit.""" | ||
|
||
from specklepy.objects import ( | ||
GIS, | ||
encoding, | ||
geometry, | ||
other, | ||
primitive, | ||
structural, | ||
units, | ||
) | ||
from specklepy.objects import encoding, geometry, other, primitive, structural, units | ||
from specklepy.objects.base import Base | ||
|
||
__all__ = [ | ||
|
@@ -19,5 +11,4 @@ | |
"units", | ||
"structural", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. shouldn't structural be removed as well? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. indeed! |
||
"primitive", | ||
"GIS", | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see some proxy classes were added, but looks like
renderMaterialProxy
is missingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm I see, shall we move it in C# accordingly as well? Right now it's not in Proxies classes list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently it relies on
RenderMaterial
which is inObjects
, notCore
. Both would have to be moved toCore
if soThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, noticed it, added it to the same place as in C#