This repository has been archived by the owner on Aug 30, 2020. It is now read-only.
implement CI check_data_consistency #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fit <100MB github requirement
derivatives/labels folder and csfseg-manual masks
Fix wrong acquisition date in participants.tsv
Implement CI testing for BIDS
Add manually corrected dwi SC segmentations.
Update dwi SC seg for sub-vuiisAchieva06
Add manually corrected dwi SC segmentations
- remove sapienza04 gmseg - correct gmseg for sapienza01
manual correction of t1w and t2w images
* fix defaced image * change permissions * add fslPrisma dataset * rename sapienza to fslAchieva * deface images * fix defacing dresden02_T2w * remove other defaced images * rename test * fix rename
|
Output from current master: |
|
@jcohenadad This PR is ready for review. |
jcohenadad
approved these changes
Aug 13, 2020
There was a problem hiding this comment.
please do not merge-- we need to wait for @kousu to tell us what to do
|
Yes. I won't, I'll wait for your approval. |
|
Sorry! You're going to have to remake this over in the remade https://github.com/spine-generic/data-multi-subject. And you'll have to add a I also would caution about running that on every CI run because that means downloading 10G to travis every time. That is going to make CI slow. Travis supports caching specific dirs: https://docs.travis-ci.com/user/caching/ but they have a warning that caching doesn't do much unless you're caching processing steps -- because each VM needs to download the data fresh each time; still it might be worth experimenting at least for an hour or two with. What if we only ran the validator in the nightly cronjob? |
Closed
Answered my own question: https://travis-ci.com/github/spine-generic/data-multi-subject-2/builds/179667411. Hard yes:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes spine-generic/data-multi-subject#24