updating the domain from 'spinoperator.dev' to 'spinkube.dev' #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Steurer <[email protected]>
| @@ -13,12 +13,13 @@ webhooks: | |||
| service: | |||
| name: '{{ include "spin-operator.fullname" . }}-webhook-service' | |||
| namespace: '{{ .Release.Namespace }}' | |||
| # TODO @asteurer: Should this filepath be updated? | |||
There was a problem hiding this comment.
Yes, the spinoperator-dev is the domain of the resource with . replaced by - to be a valid url path.
| @@ -11,7 +11,7 @@ import ( | |||
| ) | |||
|
|
|||
| // nolint:lll | |||
| //+kubebuilder:webhook:path=/mutate-core-spinoperator-dev-v1alpha1-spinapp,mutating=true,failurePolicy=fail,sideEffects=None,groups=core.spinoperator.dev,resources=spinapps,verbs=create;update,versions=v1alpha1,name=mspinapp.kb.io,admissionReviewVersions=v1 | |||
| //+kubebuilder:webhook:path=/mutate-core-spinoperator-dev-v1alpha1-spinapp,mutating=true,failurePolicy=fail,sideEffects=None,groups=core.spinkube.dev,resources=spinapps,verbs=create;update,versions=v1alpha1,name=mspinapp.kb.io,admissionReviewVersions=v1 | |||
There was a problem hiding this comment.
It needs to be changed here too.
| @@ -15,7 +15,7 @@ import ( | |||
| ) | |||
|
|
|||
| // nolint:lll | |||
| //+kubebuilder:webhook:path=/validate-core-spinoperator-dev-v1alpha1-spinapp,mutating=false,failurePolicy=fail,sideEffects=None,groups=core.spinoperator.dev,resources=spinapps,verbs=create;update,versions=v1alpha1,name=vspinapp.kb.io,admissionReviewVersions=v1 | |||
| //+kubebuilder:webhook:path=/validate-core-spinoperator-dev-v1alpha1-spinapp,mutating=false,failurePolicy=fail,sideEffects=None,groups=core.spinkube.dev,resources=spinapps,verbs=create;update,versions=v1alpha1,name=vspinapp.kb.io,admissionReviewVersions=v1 | |||
| @@ -10,7 +10,7 @@ import ( | |||
| ) | |||
|
|
|||
| // nolint:lll | |||
| //+kubebuilder:webhook:path=/mutate-core-spinoperator-dev-v1alpha1-spinappexecutor,mutating=true,failurePolicy=fail,sideEffects=None,groups=core.spinoperator.dev,resources=spinappexecutors,verbs=create;update,versions=v1alpha1,name=mspinappexecutor.kb.io,admissionReviewVersions=v1 | |||
| //+kubebuilder:webhook:path=/mutate-core-spinoperator-dev-v1alpha1-spinappexecutor,mutating=true,failurePolicy=fail,sideEffects=None,groups=core.spinkube.dev,resources=spinappexecutors,verbs=create;update,versions=v1alpha1,name=mspinappexecutor.kb.io,admissionReviewVersions=v1 | |||
| @@ -12,7 +12,7 @@ import ( | |||
| ) | |||
|
|
|||
| // nolint:lll | |||
| //+kubebuilder:webhook:path=/validate-core-spinoperator-dev-v1alpha1-spinappexecutor,mutating=false,failurePolicy=fail,sideEffects=None,groups=core.spinoperator.dev,resources=spinappexecutors,verbs=create;update,versions=v1alpha1,name=vspinappexecutor.kb.io,admissionReviewVersions=v1 | |||
| //+kubebuilder:webhook:path=/validate-core-spinoperator-dev-v1alpha1-spinappexecutor,mutating=false,failurePolicy=fail,sideEffects=None,groups=core.spinkube.dev,resources=spinappexecutors,verbs=create;update,versions=v1alpha1,name=vspinappexecutor.kb.io,admissionReviewVersions=v1 | |||
Signed-off-by: Andrew Steurer <[email protected]>
Signed-off-by: Andrew Steurer <[email protected]>
adamreese
added a commit
to adamreese/documentation
that referenced
this pull request
Sep 19, 2024
REF: spinkube/skips#5 spinkube/spin-operator#271 Signed-off-by: Adam Reese <[email protected]>
This was referenced Sep 19, 2024
|
@asteurer (or maintainer) Can you move this PR from draft to ready for review? |
asteurer
requested review from
endocrimes,
bacongobbler,
michelleN and
rajatjindal
as code owners
bacongobbler
pushed a commit
to adamreese/documentation
that referenced
this pull request
Nov 5, 2024
REF: spinkube/skips#5 spinkube/spin-operator#271 Signed-off-by: Adam Reese <[email protected]> Signed-off-by: Matthew Fisher <[email protected]>
calebschoepp
pushed a commit
to calebschoepp/documentation
that referenced
this pull request
Nov 5, 2024
REF: spinkube/skips#5 spinkube/spin-operator#271 Signed-off-by: Adam Reese <[email protected]> Signed-off-by: Matthew Fisher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @calebschoepp, this still needs a SKIP, and possibly some peripheral design work. Submitting the PR to start a those conversations