-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: option for configuring is_visible in globalConfig.json #1334
Conversation
Can you mention the use case for the suggested feature? The current implementation is, if the globalConfig file is present, the UI for the add-on should be visible by default, making it redundant to include a separate is_visible attribute in globalConfig. |
Sure, we use the UCC framework as main build pipeline for our Splunk apps. The specific use-case is an app which only contains some alert actions which doesn't require additional setup or configuration. |
Please also add that change in this file (front-end global config validation) to keep it consistent .
should work |
I've added it to meta.ts as suggested. |
Hi, if global_config:
should_be_visible = global_config.meta.get("isVisible", True) This implementation is shorter and should avoid this problem. |
@hetangmodi-crest can you please resolve the conflicts in the PR? I'll merge it tomorrow. |
Summary
Option for configuring is_visible in globalConfig.json
Changes
Checklist
If your change doesn't seem to apply, please leave them unchecked.