Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: option for configuring is_visible from globalConfig.json #1345

Merged
merged 8 commits into from
Sep 30, 2024
Merged

feat: option for configuring is_visible from globalConfig.json #1345

merged 8 commits into from
Sep 30, 2024

Conversation

hetangmodi-crest
Copy link
Contributor

Issue number: #1334

Summary

Provided option for configuring is_visible in globalConfig.json

Changes

Added the option isVisible in globalConfig.json, allowing users to configure the add-on's UI visibility directly from the globalConfig.

User experience

Users will have additional option (isVisible) in meta tag of globalConfig.json from where they can configure the add-on's UI visibility.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

@hetangmodi-crest hetangmodi-crest added the enhancement New feature or request label Sep 18, 2024
@hetangmodi-crest hetangmodi-crest self-assigned this Sep 18, 2024
@hetangmodi-crest hetangmodi-crest requested review from a team as code owners September 18, 2024 13:08
@hetangmodi-crest hetangmodi-crest mentioned this pull request Sep 18, 2024
Closed
4 tasks
soleksy-splunk
soleksy-splunk previously approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@soleksy-splunk soleksy-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hetangmodi-crest hetangmodi-crest merged commit 04c80e3 into develop Sep 30, 2024
77 checks passed
@hetangmodi-crest hetangmodi-crest deleted the feat/is_visible-in-globalConfig branch September 30, 2024 11:55
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vtsvetkov-splunk vtsvetkov-splunk vtsvetkov-splunk approved these changes

@artemrys artemrys Awaiting requested review from artemrys

@sgoral-splunk sgoral-splunk Awaiting requested review from sgoral-splunk

@kkedziak-splunk kkedziak-splunk Awaiting requested review from kkedziak-splunk

@lplonka-splunk lplonka-splunk Awaiting requested review from lplonka-splunk

@soleksy-splunk soleksy-splunk Awaiting requested review from soleksy-splunk

Assignees

@hetangmodi-crest hetangmodi-crest

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hetangmodi-crest @vtsvetkov-splunk @soleksy-splunk