Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.4.1 #149

Merged
merged 23 commits into from
Oct 4, 2024
Merged

v0.4.1 #149

merged 23 commits into from
Oct 4, 2024

Conversation

RasmusSkytte
Copy link
Contributor

@RasmusSkytte RasmusSkytte commented Jul 23, 2024 •
edited
Loading

Intent

This PR creates a version v0.4.1 which only includes the minor fixes to SCDB and not the benchmarks and optimisations (we keep those for v0.5).

This way, we can patch the exiting bugs in a timely manner
(e.g. ssi-dk/diseasystore#157 requires the fixes)

In addition, a small bug in Logger is fixed in this PR.

  • Logger would not write to the "catalog" field in the logs on backends that support catalog. This is fixed now.

Approach

The benchmark and optimisations have been reverted.

The following PRs have been revereted

Once v0.4.1 is released, we can revert the reversions and restore functionality.

I have created the PR in advance, to show that it restores functionality.
#151 contains all of the changes in this PR and the reversions to the changes such that we restore all the functionality that this PR removes.

  • The Logger patch was updated to include "catalog" on back ends that support it

Known issues

N/A

Checklist

  • The PR passes all local unit tests
  • I have documented any new features introduced
  • If the PR adds a new feature, please add an entry in NEWS.md
  • A reviewer is assigned to this PR

@RasmusSkytte
Revert "Merge pull request #137 from ssi-dk/feature/simplify_update_s…
bb14cc8 
…napshot"

This reverts commit 11bd6c6, reversing
changes made to 9fc6f5e.
@RasmusSkytte
Revert "Merge pull request #141 from ssi-dk/feature/complexity_benchm…
ceb86f9 
…ark"

This reverts commit 9fc6f5e, reversing
changes made to 34c6f23.
@RasmusSkytte RasmusSkytte added this to the v0.4.1 milestone Jul 23, 2024
@RasmusSkytte RasmusSkytte self-assigned this Jul 23, 2024
@RasmusSkytte RasmusSkytte mentioned this pull request Jul 23, 2024
Closed
19 tasks
@RasmusSkytte RasmusSkytte mentioned this pull request Jul 23, 2024
Merged
5 tasks
@RasmusSkytte RasmusSkytte marked this pull request as ready for review July 23, 2024 12:34
@RasmusSkytte RasmusSkytte requested review from a team, SofiaOtero and LasseEngboChr and removed request for a team July 23, 2024 13:19
@RasmusSkytte RasmusSkytte merged commit ce303b2 into main Oct 4, 2024
28 checks passed
@RasmusSkytte RasmusSkytte deleted the rc-v0.4.1 branch October 4, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LasseEngboChr LasseEngboChr LasseEngboChr approved these changes

@SofiaOtero SofiaOtero Awaiting requested review from SofiaOtero SofiaOtero was automatically assigned from ssi-dk/ddf

Assignees

@RasmusSkytte RasmusSkytte

Labels
None yet
Projects
None yet
Milestone
v0.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@RasmusSkytte @LasseEngboChr