Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore main after release of v0.4.1 #151

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Restore main after release of v0.4.1 #151

merged 3 commits into from
Oct 4, 2024

Conversation

RasmusSkytte
Copy link
Contributor

@RasmusSkytte RasmusSkytte commented Jul 23, 2024 •
edited
Loading

Intent

This PR restores the functionality merged to main before the intermittent release of v0.4.1.
(#149 and #150)

I am adding this PR now, before merging #149 to verify that this will completely restore main.

Approach

The reversions from #149 was reverted to restore the functionality added in
#131, #137, #138 and #141.

Known issues

  • This PR can be merged following the release of v0.4.1

Checklist

  • The PR passes all local unit tests
  • I have documented any new features introduced
  • If the PR adds a new feature, please add an entry in NEWS.md
  • A reviewer is assigned to this PR

@RasmusSkytte RasmusSkytte changed the base branch from rc-v0.4.1 to main July 23, 2024 12:33
@RasmusSkytte RasmusSkytte mentioned this pull request Jul 23, 2024
Merged
9 tasks
@RasmusSkytte RasmusSkytte self-assigned this Sep 26, 2024
@RasmusSkytte
chore: Increment version number to 0.4.1.9000
6e00f62
@RasmusSkytte
chore: Restore #131, #137, #138 and #141
913a0ae 
This reverts commit bff2007.
This reverts commit ce6b09c.
This reverts commit ceb86f9.
This reverts commit bb14cc8.
@RasmusSkytte RasmusSkytte marked this pull request as ready for review October 4, 2024 07:57
@RasmusSkytte RasmusSkytte merged commit 75a17b8 into main Oct 4, 2024
27 checks passed
@RasmusSkytte RasmusSkytte deleted the restore-main branch October 4, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@RasmusSkytte RasmusSkytte

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RasmusSkytte