Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move validated Hostname type from secret-operator #851

Merged
merged 12 commits into from
Sep 3, 2024
Merged

Move validated Hostname type from secret-operator #851

merged 12 commits into from
Sep 3, 2024

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Aug 28, 2024 •
edited
Loading

Description

Also refactors the validation module to use typed errors.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Beta Give feedback

Reviewer
Beta Give feedback

Acceptance
Beta Give feedback

@nightkr
Copy link
Member Author

nightkr commented Aug 29, 2024

Corresponding secret-op PR: stackabletech/secret-operator#494

@nightkr nightkr mentioned this pull request Aug 29, 2024
Merged
@nightkr nightkr marked this pull request as ready for review August 29, 2024 17:43
@nightkr
Copy link
Member Author

nightkr commented Aug 29, 2024

Tests are green on the secret-op side: stackabletech/secret-operator#494

@nightkr nightkr requested a review from a team August 29, 2024 17:44
NickLarsenNZ
NickLarsenNZ previously approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crates/stackable-operator/src/validation.rs Show resolved Hide resolved
Techassi
Techassi requested changes Aug 30, 2024
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mostly minor comments.

crates/stackable-operator/CHANGELOG.md Outdated Show resolved Hide resolved
crates/stackable-operator/src/commons/networking.rs Outdated Show resolved Hide resolved
crates/stackable-operator/src/commons/networking.rs Outdated Show resolved Hide resolved
crates/stackable-operator/src/validation.rs Show resolved Hide resolved
crates/stackable-operator/src/validation.rs Outdated Show resolved Hide resolved
crates/stackable-operator/src/validation.rs Outdated Show resolved Hide resolved
crates/stackable-operator/src/validation.rs Show resolved Hide resolved
crates/stackable-operator/src/validation.rs Show resolved Hide resolved
@nightkr nightkr added this pull request to the merge queue Sep 3, 2024
Merged via the queue into main with commit 96217cf Sep 3, 2024
20 checks passed
@nightkr nightkr deleted the feature/validation-hostname branch September 3, 2024 13:34
@sbernauer
Copy link
Member

@nightkr are we planning on using this new types in AuthClass OIDC and LDAP providers?

@Techassi Techassi mentioned this pull request Sep 19, 2024
Merged
@nightkr
Copy link
Member Author

nightkr commented Sep 20, 2024

If it's appropriate there? ^^

@sbernauer
Copy link
Member

Yep, #863 switched to using an (although slight different) HostName struct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ left review comments

@Techassi Techassi Techassi approved these changes

Assignees

@nightkr nightkr

Labels
None yet
Projects
Stackable Engineering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nightkr @sbernauer @NickLarsenNZ @Techassi