Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream Hostname into operator-rs #494

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Aug 29, 2024

Description

It's becoming useful in other operators, so let's try to share it.

As a bonus, by reusing the validation machinery in op-rs we can also add the validation rules to the CRD.

Op-rs equivalent: stackabletech/operator-rs#851

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

@nightkr nightkr marked this pull request as draft August 29, 2024 13:11
@nightkr nightkr marked this pull request as ready for review August 29, 2024 13:11
@nightkr nightkr marked this pull request as draft August 29, 2024 13:11
@nightkr
Copy link
Member Author

nightkr commented Aug 29, 2024

The tests are green against kind, but red against OpenShift due to some SCC profile errors.. @razvan could this be related to #488?

@razvan
Copy link
Member

razvan commented Aug 29, 2024

The tests are green against kind, but red against OpenShift due to some SCC profile errors.. @razvan could this be related to #488?

No. It looks like you forgot to pass --test-suite openshift to the job parameters.

@nightkr
Copy link
Member Author

nightkr commented Aug 29, 2024

Oh, that's not automatic? Gotcha.

@nightkr
Copy link
Member Author

nightkr commented Aug 29, 2024

@nightkr
Copy link
Member Author

nightkr commented Aug 29, 2024

Openshift is green once running the correct suite.. :P

@nightkr nightkr marked this pull request as ready for review August 29, 2024 17:44
@nightkr nightkr requested a review from a team August 29, 2024 17:44
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer
Copy link
Member

FYI, I put this issue on the board so that everyone has a chance to follow development :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Development: In Review
Development

Successfully merging this pull request may close these issues.

4 participants