-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stacks-explorer fails to compile #350
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #350 +/- ##
=======================================
Coverage 43.44% 43.44%
=======================================
Files 45 45
Lines 5467 5467
Branches 47 47
=======================================
Hits 2375 2375
Misses 3091 3091
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@AshtonStephens who else can review this? |
Summary of Changes
CI has been failing lately. These changes fixed it for me. I ported the changes from the Hiro dockerfile for stacks-explorer.
Evidence:
https://github.com/stacks-network/sbtc/actions/runs/6578085435/job/18167621690?pr=303
Testing
Risks
How were these changes tested?
Locally and in CI for open PRs.
What future testing should occur?
Checklist: