-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual fix to issue#287 for Hironx. #290
Conversation
dd02403
to
f140c62
Compare
f140c62
to
3144ff6
Compare
created test code for #287 and why you create new unittest under nextage? |
What is the plan ? since robot_model is likely to update to new version on next sync, are you going to merge this and create new version now, and remove this and create new version after next sync? and release reverted version on next-next sync? |
#287 (comment) tells all. We don't need this patch.
Because the model file is different b/w |
Ok, I understand, I just curious that it seems you create test code for nxo only not hiro. |
Hello everyone, Is the deviation always in the Z direction? If so, it could be because the Best regards, Hajime 2015-03-05 21:24 GMT+09:00 uesnaola [email protected]:
|
@uesnaola Is it possible for you to share the code you use to publish your custom tf frames ( @emijah Once we have the code is it possible for you to try reproducing the issue on the real robot? Lacking both the code and the real robot, it's a bit hard for me to replicate the issue. And in response to @emijah,
Assuming this is true, then,
I think this is the opposite.
If the above is true then Ref. #213 (comment) After all, I can't yet explain why @uesnaola is seeing this issue. |
CORRECTION: x: If the above is true then
|
Applying the change suggested in #287 (comment) for left and right arms.
As far as checked visually (making unittest for this issue is in progress at tork-a/rtmros_nextage#133), it looked ok.