Support for constructor-related functionality in Soroban SDK. #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmkozh
force-pushed
the
ctor_bump
branch
2 times, most recently
from
a7ac4f4
to
5c43fca
Compare
dmkozh
force-pushed
the
ctor_bump
branch
2 times, most recently
from
5cdb384
to
6385e06
Compare
leighmcculloch
added a commit
that referenced
this pull request
Sep 16, 2024
This fix is extracted from #1327 by @dmkozh. Co-authored-by: Dmytro Kozhevin <[email protected]>
leighmcculloch
approved these changes
Sep 16, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 16, 2024
### What Panic if the number of args being passed to a natively registered contract don't match the number of args the contract function expects. ### Why This bug exists only in the testutils path of invoking a natively registered contract and does not impact WASM registered contracts, or the env as deployed. If a native contract is invoked with too few arguments, a panic occurs with an index out of bounds errors that is not intuitive to debug. The panic displayed to the developer should be as intuitive as possible. - Before: `index out of bounds: the len is 1 but the index is 1` - After: `invalid number of input arguments: 2 expected, got 1` If a native contract is invoked with too many arguments, no panic occurs, the additional arguments are simply ignored. The behaviour of invoking natively registered contracts in testutils should be as consistent as possible to invoking contracts on a deployed network. In both of these cases the invoke fails. - Before: no panic - After: `invalid number of input arguments: 2 expected, got 3` Thanks to @dmkozh who fixed this bug and proposed the better error experience in #1327 which is destined for the next major release of the sdk v22, and this pull request extracts the fix in isolation so we can release a bug fix release of the sdk v21. --------- Co-authored-by: Dmytro Kozhevin <[email protected]>
The main non-test changes are updates for the auth-related data structures and a wrapper for the new deployer function (create_contract_with_constructor). The remaining changes concern the test infrastructure support, specifically contract creation utilities that support passing constructor arguments.
leighmcculloch
approved these changes
Sep 16, 2024
leighmcculloch
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The main non-test changes are updates for the auth-related data structures and a wrapper for the new deployer function (
create_contract_with_constructor).The remaining changes concern the test infrastructure support, specifically contract creation utilities that support passing constructor arguments.
Why
Supporting constructors introduced in protocol 22.
Known limitations
N/A