Fix compiler error with latest compilers. #23
+9
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the latest compilers (gcc 11 and up), there are errors compiling this package. The compilers warn about variadic macros needing at least one argument. This fixes that warning by making sure that is always the case using a %s specifier. With this in place, the compiler warnings are gone. Signed-off-by: Chris Lalancette <[email protected]>
This was referenced May 23, 2023
|
@stonier Friendly ping on this one, it would be nice to get this merged and released. |
|
@stonier Another friendly ping on this one. As an alternative, we could also consider giving me write access to this repository so that I could merge and do releases. Let me know. |
|
@stonier Another friendly ping. |
YuZhong-Chen
added a commit
to YuZhong-Chen/ros2-essentials
that referenced
this pull request
Nov 15, 2023
Fix for the compiler error that occurs with the latest compilers (gcc 11 and up) when compiling sophus. Reference: stonier/sophus#23
YuZhong-Chen
added a commit
to YuZhong-Chen/ros2-essentials
that referenced
this pull request
Nov 15, 2023
Fix for the compiler error that occurs with the latest compilers (gcc 11 and up) when compiling sophus. Reference: stonier/sophus#23
YuZhong-Chen
added a commit
to YuZhong-Chen/ros2-essentials
that referenced
this pull request
Dec 1, 2023
Fix for the compiler error that occurs with the latest compilers (gcc 11 and up) when compiling sophus. Reference: stonier/sophus#23
YuZhong-Chen
added a commit
to YuZhong-Chen/ros2-essentials
that referenced
this pull request
Dec 22, 2023
Fix for the compiler error that occurs with the latest compilers (gcc 11 and up) when compiling sophus. Reference: stonier/sophus#23
YuZhong-Chen
added a commit
to YuZhong-Chen/ros2-essentials
that referenced
this pull request
Dec 29, 2023
Fix for the compiler error that occurs with the latest compilers (gcc 11 and up) when compiling sophus. Reference: stonier/sophus#23
YuZhong-Chen
added a commit
to YuZhong-Chen/ros2-essentials
that referenced
this pull request
Dec 29, 2023
Fix for the compiler error that occurs with the latest compilers (gcc 11 and up) when compiling sophus. Reference: stonier/sophus#23
|
@stonier Another friendly ping here. |
|
@stonier Can we get this merged please? |
clalancette
added a commit
to ros/rosdistro
that referenced
this pull request
Mar 15, 2024
We've been waiting for almost a year to get some fixes to sophus merged so that we can get turtlebot2 released into Humble and Iron: stonier/sophus#23 For now, use a fork under my username to do the release. I still haven't merged that fix in, but once we switch this over I will have the power to do so. While we are in here, switch the source and doc branches to be correct (we are releasing from the 1.3.x branch nowadays). Signed-off-by: Chris Lalancette <[email protected]>
clalancette
added a commit
to ros/rosdistro
that referenced
this pull request
Mar 18, 2024
We've been waiting for almost a year to get some fixes to sophus merged so that we can get turtlebot2 released into Humble and Iron: stonier/sophus#23 For now, use a fork under my username to do the release. I still haven't merged that fix in, but once we switch this over I will have the power to do so. While we are in here, switch the source and doc branches to be correct (we are releasing from the 1.3.x branch nowadays). Signed-off-by: Chris Lalancette <[email protected]>
|
friendly ping :) |
KalanaRatnayake
added a commit
to CollaborativeRoboticsLab/sophus
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the latest compilers (gcc 11 and up), there are errors compiling this package. The compilers warn about variadic macros needing at least one argument.
This fixes that warning by making sure that is always the case using a %s specifier. With this in place, the compiler warnings are gone.
@stonier We could really use a merge and release of this fix, as that will allow the kobuki stuff to be released into both Humble and Iron. Thanks in advance.