Default to K8s 1.28 in e2e #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other GHAs were changed to default to 1.28, but the custom GHA used throughout Submariner wasn't updated and still defaulted to 1.25. This fixes that. Signed-off-by: Stephen Kitt <[email protected]>
skitt
requested review from
Oats87,
sridhargaddam and
tpantelis
as code owners
|
🤖 Created branch: z_pr1538/skitt/default-e2e-1.28 |
|
Shouldn't we default to 1.29? |
Not if we want to be able to run the e2e jobs — we can update this once we get a new version of kind. |
tpantelis
approved these changes
Jan 25, 2024
|
#1539 should fix the cleanup failures. |
4 tasks
aswinsuryan
approved these changes
Jan 29, 2024
|
🤖 Closed branches: [z_pr1538/skitt/default-e2e-1.28] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other GHAs were changed to default to 1.28, but the custom GHA used throughout Submariner wasn't updated and still defaulted to 1.25. This fixes that.