feat(substrait): Update to Substrait v0.53.0 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
anshuldata
commented
Aug 6, 2024
•
anshuldata
commented
- Update substrait proto dependency to v0.53.0
- go generate
- Fixed Literal methods to accommodate breaking user defined type changes (this one)
- Fixed AdvancedExtenstion interface to accomodate breaking change (this one)
- Added linter directive in files using deprecated fields. "staticcheck" doesn't seem to have config to ignore a particular check so ignoring "deprecated field" check in files which are using deprecated fields
* Update substrait proto dependency to v0.53.0
* go generate
…of in proto instead of direct value
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
=======================================
Coverage ? 46.38%
=======================================
Files ? 15
Lines ? 5553
Branches ? 0
=======================================
Hits ? 2576
Misses ? 2809
Partials ? 168 ☔ View full report in Codecov by Sentry. |
|
There are fields which are deprecated. I need to fix linter. Marking this PR as Draft |
anshuldata
changed the title
* staticcheck doesn't have a ignore "check" at global level. So to fix quickly using linter directive
jacques-n
changed the title
jacques-n
changed the title
jacques-n
changed the title
jacques-n
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.